Skip to content

Conversation

@emrikol
Copy link

@emrikol emrikol commented Jun 19, 2019

esc_url() should be used for src attributes instead of esc_attr()

Summary

This PR can be summarized in the following changelog entry:

Addresses issue #

Relevant technical choices

Checklist:

`esc_url()` should be used for `src` attributes instead of `esc_attr()`
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@emrikol
Copy link
Author

emrikol commented Jun 19, 2019

Closing: Not worth signing the CLA over this 🤷‍♂️

@swissspidy
Copy link
Contributor

No worries @emrikol, we'll try to fix this issue nonetheless.

@ghost
Copy link

ghost commented Jun 21, 2019

@googlebot @swissspidy
I think this update should be approved!

@swissspidy
Copy link
Contributor

@sviluppomania if the CLA is not signed by the author we cannot merge pull requests.

However, this definitely encourages us to audit existing escaping functions and to potentially improve the code base in this regard.

github-actions bot referenced this pull request in benbowler/site-kit-wp Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants