Skip to content

Removes babel-plugin-makepot package from the build process #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felixarntz merged 2 commits into from
Jun 24, 2019
Merged

Removes babel-plugin-makepot package from the build process #15

felixarntz merged 2 commits into from
Jun 24, 2019

Conversation

@ivankristianto
Copy link
Contributor

@ivankristianto ivankristianto commented Jun 20, 2019 •
edited by felixarntz
Loading

Summary

Currently we have an error with the build process because of the translation.pot not exist anymore.

This PR can be summarized in the following changelog entry:

  • Remove translation file generator from build process and the @wordpress/babel-plugin-makepot package.

Fixes #17

Relevant technical choices

Translation will be handled by polyglots.

Checklist:

@ivankristianto ivankristianto added the Type: Bug Something isn't working label Jun 20, 2019
@ThierryA ThierryA added this to the Hot Fixes Release milestone Jun 20, 2019
@ThierryA ThierryA removed the Type: Bug Something isn't working label Jun 20, 2019
@ThierryA ThierryA removed this from the Hot Fixes Release milestone Jun 20, 2019
@ThierryA
Copy link
Collaborator

ThierryA commented Jun 20, 2019

@ivankristianto could you open an issue to link this PR to it. As a rule of thumb, we are tracking issues and associating PRs to it.

@ivankristianto ivankristianto added the Type: Bug Something isn't working label Jun 20, 2019
@ivankristianto
Copy link
Contributor Author

ivankristianto commented Jun 20, 2019

@ThierryA issue open in #17

@swissspidy
Copy link
Contributor

swissspidy commented Jun 21, 2019

This totally makes sense. Plugins eventually ending up on dotorg don‘t need POT files, especially not incomplete JS-only ones.

@felixarntz felixarntz added this to the Hot Fixes Release milestone Jun 24, 2019
@felixarntz felixarntz added the P0 High priority label Jun 24, 2019
@felixarntz
Copy link
Member

felixarntz commented Jun 24, 2019

@ivankristianto I updated the changelog regarding the following:

  • There should only be one changelog message per PR.
  • The changelog message should start with an infinitive verb (e.g. "Add", "Remove", "Fix", ...).

Please keep that in mind for the future.

@felixarntz felixarntz mentioned this pull request Jun 24, 2019
Merged
6 tasks
@felixarntz felixarntz merged commit fb5e001 into develop Jun 24, 2019
@felixarntz felixarntz removed Type: Bug Something isn't working P1 Medium priority P0 High priority labels Jun 27, 2019
@felixarntz felixarntz removed this from the 1.0.0-beta.1.1 milestone Jun 27, 2019
@felixarntz felixarntz deleted the fix/webpack-build-error branch July 4, 2019 11:34
@yescit yescit mentioned this pull request Aug 7, 2023
Closed
github-actions bot pushed a commit to benbowler/site-kit-wp that referenced this pull request Jun 17, 2025
@actions-user
Update E2E stability test results (run google#15) [skip ci]
9896e24
github-actions bot pushed a commit to benbowler/site-kit-wp that referenced this pull request Jun 18, 2025
@actions-user
Update backstop stability test results (run google#15) [skip ci]
eff007e
@jamesozzie jamesozzie mentioned this pull request Jul 4, 2025
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixarntz felixarntz felixarntz approved these changes

@ryansommers ryansommers Awaiting requested review from ryansommers

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Webpack build throw babel make-pot error

4 participants

@ivankristianto @ThierryA @swissspidy @felixarntz