-
Notifications
You must be signed in to change notification settings - Fork 328
[SK] Prototype for SFR Phase 1 #11058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
[SK] Prototype for SFR Phase 1 #11058
Conversation
83db04c to
cc87bf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in the design doc, we'll probably want to create a new version of this component rather than modifying it.
The same applies to the components UserInputQuestionInfo, UserInputQuestionNotice, UserInputQuestionWrapper and UserInputQuestionnaire.
| export function getUserInputQuestions() { | ||
| const description = __( | ||
| 'Based on your answer, Site Kit will suggest the metrics you see on your dashboard to help you track how close you’re getting to your specific goals', | ||
| 'Which option most closely matches the purpose of your site?', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, we'll want to create a new version of this function (or provide an alternative data structure), rather than modifying it.
…tion, from the Analytics module setup.
…nt creation (provisioning).
…tial Analytics module setup flow.
…g Analytics account outside of the setup flow.
cc87bf7 to
f095a75
Compare
…ding to the redirect URL.
… creation status.
c5c7331 to
6f76ddc
Compare
…setups, replacing the "account created" notification.
a0ba038 to
107db0f
Compare
… here as it's added via the `googlesitekit_auth_scopes` hook.
df9dcd0 to
868c70f
Compare
Summary
This is the plugin-side prototype for Phase 1 of the Setup Flow Refresh Epic. Do not merge.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist