-
Notifications
You must be signed in to change notification settings - Fork 357
Making AdSense CTA accessible #9289
Copy link
Copy link
Closed
Labels
Module: AdSenseGoogle AdSense module related issuesGoogle AdSense module related issuesP2Low priorityLow priorityTeam MIssues for Squad 2Issues for Squad 2Type: EnhancementImprovement of an existing featureImprovement of an existing feature
Metadata
Metadata
Assignees
Labels
Module: AdSenseGoogle AdSense module related issuesGoogle AdSense module related issuesP2Low priorityLow priorityTeam MIssues for Squad 2Issues for Squad 2Type: EnhancementImprovement of an existing featureImprovement of an existing feature
Type
Fields
Give feedbackNo fields configured for issues without a type.
Feature Description
On the AdSense CTA within the SK dashboard, the sub-text when not highlighted appears as an accessibility issue for the contrast.
Steps to reproduce:
Details
Suggestion : To make the points that are not highlighted accessible. It might require some discussion on how best to achieve that.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
assets/sass/components/setup/_googlesitekit-adsense-connect-cta.scss— bump the un-highlightedh4andpto surfaces/on-background-variant (#6C726E) so idle slides meet ≥ 4.5:1 contrast while preserving the active-state brand palette and transition classes.Test Coverage
QA Brief
#6C726E(rgb(108, 114, 110)) for bothh4andpelements.Changelog entry