-
Notifications
You must be signed in to change notification settings - Fork 328
Closed
Labels
Module: AnalyticsGoogle Analytics module related issuesGoogle Analytics module related issuesP1Medium priorityMedium priorityTeam MIssues for Squad 2Issues for Squad 2Type: EnhancementImprovement of an existing featureImprovement of an existing featureType: SupportSupport requestSupport request
Description
Bug Description
When reviewing a support topic, the plugin is outputting the same error message multiple times within the all traffic widget.
- Support topic from impacted user
- SH info from impacted user
- There is an open GitHub issue regarding limiting API requests: Limit API requests when the user doesn't have access to the connected entity #7033
- There is also an open GH issue regarding multiple errors, but from the main WordPress dashboard: Don't display multiple errors on the main WordPress dashboard #6377
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- Error messages caused by access token refresh issues are grouped, and only one is shown in the scope of a widget
Implementation Brief
- In
assets/js/components/ReportError.js:- Update the script that filters unique errors to remove the
codeargument from thereconnectURLvalues before comparing them. - The
codeparameter contains a session ID, and it can be different for different requests, thus we need to ignore it.
- Update the script that filters unique errors to remove the
Test Coverage
- Add a new test to
ReportErrortests to verify the new functionality.
QA Brief
- Follow the steps in this issue's QAB
- Ensure that only one instance of the error is shown
Changelog entry
- Improve error reporting in Site Kit widgets to not report duplicate errors.
Metadata
Metadata
Assignees
Labels
Module: AnalyticsGoogle Analytics module related issuesGoogle Analytics module related issuesP1Medium priorityMedium priorityTeam MIssues for Squad 2Issues for Squad 2Type: EnhancementImprovement of an existing featureImprovement of an existing featureType: SupportSupport requestSupport request
