Skip to content

Duplicate 'X' on 'Data gathering complete' modal #12618

@kelvinballoo

Description

@kelvinballoo

Bug Description

For Data gathering complete scenario, there are double 'x' icons/buttons at smaller breakpoints.

Refer to the attached image. We should only have 1.

Details Image

Steps to reproduce

  1. Set up SK with Setup Flow Refresh Flag on.
  2. Welcome modal will appear.
  3. Got to tester plugin and Force Search Console report data to 'zero'.
  4. Go back to the dashboard, the 'Data gathering complete' modal will appear.
  5. Resize to smaller breakpoints e.g. 320 x 525 to notice the double 'X'

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The "data gathering complete" variant of the Welcome modal shows a single close icon when viewed at any breakpoint.

Implementation Brief

  • Edit the assets/svg/graphics/welcome-modal-data-gathering-complete-graphic.svg file to remove the unwanted close icon.
    • Specifically, delete lines 25-27. I've included an IDE screenshot, as it's not possible to permalink to codelines on GitHub for an SVG.
Image

Test Coverage

  • Fix any failing stories.

QA Brief

Changelog entry

  • Fix double 'X' icons/buttons for 'Data gathering complete' variant of the Welcome modal.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Good First IssueGood first issue for new engineersP1Medium priorityTeam MIssues for Squad 2Type: BugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions