Skip to content

The Analytics/AdSense linked overlay notification interferes with the welcome tour #12478

@abdelmalekkkkk

Description

@abdelmalekkkkk

When the AnalyticsAndAdSenseAccountsDetectedAsLinkedOverlayNotification notification is present, it hides everything below it, including all the elements that are showcased during the welcome tour.

Steps to reproduce

  1. Set up Site Kit with AdSense
  2. Share the dashboard with another user
  3. The second user will see both the overlay and the welcome modal at the same time

Screenshots

Image Image

Additional Context

  • PHP Version:
  • OS: [e.g. iOS]
  • Browser: [e.g. chrome, safari]
  • Plugin Version: [e.g. 22]
  • Device: [e.g. iPhone6]

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • No overlay notification should appear when the dashboard tour is in progress.

Implementation Brief

  • In assets/js/components/DashboardMainApp.js
    • Use getCurrentTour selector from core/user store to check if any tour is in progress.
    • If the current tour is welcome-without-analytics or welcome-with-analytics, we should not render this block of code to avoid rendering overlay notifications.

Test Coverage

  • Not required.

QA Brief

  1. Set up Site Kit with AdSense
  2. Share the dashboard with another user
  3. The second user won't see the overlay notification when welcome tour is in progress, it will be visible only after dismissing/completing the tour.

Changelog entry

  • Prevent overlay notifications from appearing when the dashboard tour is active.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P0High priorityTeam MIssues for Squad 2Type: BugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions