Feature Description
The Welcome modal will be updated for mobile viewports to show the background overlay, rather than being full-screen.
Additionally, the modal will not show its graphic for very short viewports where the presence of the graphic would prevent the modal’s title and description from being visible without scrolling.
For reference, see the Welcome modal section in the design doc, the Figma design, and this Asana task raised in the Phase 2 bug bash.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- On mobile viewports, the Welcome modal shows the background overlay behind it, rather than being full-screen.
- On very short viewports where the graphic would prevent the modal's title and description from being visible without scrolling, the graphic is hidden.
- These changes are gated by the
setupFlowRefresh feature flag.
- The modal matches the Figma design.
Implementation Brief
Note: The changes can be seen in this diff, this branch can be used as a reference for implementation.
Test Coverage
QA Brief
-
Enable setupFlowRefresh feature flag and complete the setup flow. Ensure that the site has data available so that welcome modal shows.
-
When setup flow is completed and welcome modal appears.
-
Check the welcome modal on smaller viewports (mobile and tablet), the background overlay should be visible and modal should be placed at the center of the viewport.
-
For smaller devices where height is less than 520px, the welcome modal graphic should not be visible and only title and description should be visible.
-
Make sure the modal matches the Figma design provided in AC.
Changelog entry
- Update the dashboard's Welcome modal for mobile viewports.
Feature Description
The Welcome modal will be updated for mobile viewports to show the background overlay, rather than being full-screen.
Additionally, the modal will not show its graphic for very short viewports where the presence of the graphic would prevent the modal’s title and description from being visible without scrolling.
For reference, see the Welcome modal section in the design doc, the Figma design, and this Asana task raised in the Phase 2 bug bash.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
setupFlowRefreshfeature flag.Implementation Brief
Note: The changes can be seen in this diff, this branch can be used as a reference for implementation.
In
assets/js/components/WelcomeModal.tsxgooglesitekit-dialog--with-mobile-marginstoDialogcomponent which can be reused to style modals for mobile and tablet viewport.In
assets/sass/components/global/_googlesitekit-dialog.scssalign-itemsfor mobile viewports(width < $bp-tablet)..mdc-dialog__container, use the$grid-gap-phonemargins side wide and it's height should be set toautowithmax-heightset to slightly less than100vhso that modal is completely visible in viewport..mdc-dialog__surface, add border radius$br-md.In
assets/sass/components/dashboard/_googlesitekit-welcome-modal.scss.googlesitekit-welcome-modal__graphic), set it todisplay: noneTest Coverage
QA Brief
Enable
setupFlowRefreshfeature flag and complete the setup flow. Ensure that the site has data available so that welcome modal shows.When setup flow is completed and welcome modal appears.
Check the welcome modal on smaller viewports (mobile and tablet), the background overlay should be visible and modal should be placed at the center of the viewport.
For smaller devices where height is less than
520px, the welcome modal graphic should not be visible and only title and description should be visible.Make sure the modal matches the Figma design provided in AC.
Changelog entry