Skip to content

Fix multiple issues with email reporting panel #11957

@benbowler

Description

@benbowler

Bug Description


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • When the Email Reports feature is disabled in Admin Settings, nothing other than the notice should be displayed in the Email Reporting Settings side panel as per this Figma mock.
  • The footer within the Email reporting side panel should NOT end in a full stop and should be updated as follows:
    • All email reports sent are generated by Site Kit using data from your dashboard and sent to your WordPress email, so all your data stays with you
  • Similar to the Key Metrics and Audience Segmentation panels, the Email Reporting settings panel content should be scrollable but have a "fixed" header and footer.
  • When a frequency has been selected, there should be a 10px gap between the Unsubscribe and Update Settings button as per this figma mock.
  • The Email Reporting Disabled notice is made up of 2 sentences, so the second sentence should also end with a full stop.

Implementation Brief

Since the 'fixes' involved were minor, the following points have already been actioned in the PR attached to this issue and the QAB is already given. So this issue can be moved straight to CR.

  • Use the isEmailReportingEnabled selector on the core/site datastore and conditionally render the panel content and SelectionPanelFooter.
  • Update the wording of the footer text as per the AC.
  • Add overflow: auto to the googlesitekit-user-settings-selection__panel-content class. Ensure the Header is removed out of this div and adjust paddings accordingly.
  • Add a flex gap: 10px between the buttons in googlesitekit-selection-panel-subscribe-actions.

Test Coverage

  • No new tests required.

QA Brief

  • Ensure Email Reporting is enabled (be sure to enable the proactiveUserEngagement feature flag)
  • Test the Email Reporting settings side panel in multiple conditions to ensure the ACs are met:
    • When Email Reporting is disabled (both for admin and view-only users): the side panel should only contain the notice as per the Figma mock.
    • When analytics is disconnected, the side panel should continue to show everything along with the notice.
    • When both Email Peporting is enabled and Analytics is connected, the side panel should continue to show everything without any notices.
    • When a frequency has and has not been selected, the Unsubscribe button when displayed should now have a 10px gap.

Changelog entry

  • Fix bugs with email reporting panel in various states.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P0High priorityTeam SIssues for Squad 1Type: BugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions