-
Notifications
You must be signed in to change notification settings - Fork 328
Closed
Labels
P0High priorityHigh priorityTeam MIssues for Squad 2Issues for Squad 2Type: BugSomething isn't workingSomething isn't working
Description
Bug Description
The plugin version is missing in the plugin's internal event tracking since 1.163.0. This coincides with several major upgrades that happened between this and the previous release, primarily around Node and Webpack.
Steps to reproduce
- Enable tracking in Admin settings or from splash page
- Inspect session with Tag Assistant
- Load a Site Kit screen (e.g. dashboard)
- See missing
plugin_versionparameter in Tag Assistant
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- The current plugin version should always be present in all internal events as the Event Parameter
plugin_version
Implementation Brief
- In
assets/js/util/tracking/index.js:- Instead of destructuring
GOOGLESITEKIT_VERSIONfromglobaland assigning it topluginVersion, avoid destructuring and refer to the property directly. This destructuring no longer works since upgrading Node and Webpack. - Add a comment to the direct reference code explaining why we can't use destructuring, (see: Plugin version attribution missing in internal event tracking #11802 (comment))
- Instead of destructuring
Test Coverage
- Add an E2E test that does the following:
- Turns on tracking.
- Inspects the
configproperty ofwindow._googlesitekitDataLayerand verifies that the necessary configuration is set, including at least theplugin_versionand if time permits, the other configs as set here.
QA Brief
- Use the steps to reproduce mentioned in the issue description.
- Verify that the
plugin_versionis present and correctly set in the event payload.
Changelog entry
- Fix internal event tracking to include plugin version information.
nfmohit
Metadata
Metadata
Assignees
Labels
P0High priorityHigh priorityTeam MIssues for Squad 2Issues for Squad 2Type: BugSomething isn't workingSomething isn't working