Skip to content

Ensure all banner content has a maximum width to match the dashboard content. #11800

@jamesozzie

Description

@jamesozzie

Bug Description

The content of some banners, such as the Sign in with Google warning banner, spread wider than the standard container. They're outside the googlesitekit-page-content container, so this may be normal. For other banners, even those above the mentioned div, the content is at least set to a maximum width to match the main content area.

For consistency, consider setting a max width to the content for all warnings.

Example below for the Sign in with Google banner, the yellow frame extends beyond most of the content.
Image

Example below for a set up notification banner, where the width is contained

Image

Example below for a error notification, where the banner itself is full width, with the content contained.

Image


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The SiwG Compatibility notice on the dashboard should fit within the centre aligned page content (the max width of the plugin).

Implementation Brief

The following has already been implemented in the attached PR and can be moved straight to QA.

  • In assets/js/modules/sign-in-with-google/index.js, update the areaSlug to NOTIFICATION_AREAS.DASHBOARD_TOP instead of NOTIFICATION_AREAS.HEADER.

Test Coverage

  • No new tests required.

QA Brief

  • Setup the SiwG module in the plugin.
  • Now install the WPS Hide Login plugin.
  • Verify the warning notice that appears on the dashboard for Sign in with Google is centred and limited to the page content.
Screenshot Image

Changelog entry

  • Fix banner width for Sign in with Google content on very large displays.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions