Skip to content

Enhanced measurement settings are requested twice on the dashboard #11766

@aaemnnosttv

Description

@aaemnnosttv

Bug Description

We recently changed how notifications are checked for being active on the dashboard in GA as part of #11663.
In doing so, some resolvers were changed which has introduced a regression where it's possible for the enhanced measurement settings to be requested twice.

Steps to reproduce

  1. Set up GA
  2. Visit dashboard
  3. See duplicate request for enhanced-measurement-settings

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Enhanced measurement settings should only be requested once over the network per page load

Implementation Brief

  • Update all enhanced measurement selectors with resolvers (other than getEnhancedMeasurementSettings) to resolveSelect -> getEnhancedMeasurementSettings rather than copying/duplicating the same resolver
    • i.e. isEnhancedMeasurementStreamEnabled and isEnhancedMeasurementStreamAlreadyEnabled
  • See Fix duplicate requests for enhanced measurement settings #11767

Test Coverage

  • No changes. While this is possible to reproduce in a test, it's a bit cumbersome to do as it requires returning the response async, otherwise the response is essentially received instantly and doesn't reproduce the issue. This should ideally be addressed at a higher level though rather than at the individual selector level and so new issues will be opened to address this holistically.

QA Brief

  • See steps to reproduce. Only a single request for EM settings should be made on the dashboard where previously it was triggering twice.

Changelog entry

  • Prevent an unnecessary request to the enhanced-measurement-settings endpoint when loading the dashboard.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Module: AnalyticsGoogle Analytics module related issuesP1Medium priorityTeam MIssues for Squad 2Type: BugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions