-
Notifications
You must be signed in to change notification settings - Fork 328
Closed
Labels
P1Medium priorityMedium priorityTeam MIssues for Squad 2Issues for Squad 2Type: EnhancementImprovement of an existing featureImprovement of an existing feature
Description
Feature Description
The "Learn more" links in Enhanced Conversions notices (both dashboard notifications and settings notices) currently hide the external link indicator by using the hideExternalIndicator prop. This is inconsistent with other notices and links throughout Site Kit, which use the external icon to indicate that the link opens an external URL.
The external indicator should be shown for these links to improve UX consistency and better inform users that clicking the "Learn more" link will navigate to an external documentation page.
This affects the following components:
- Analytics-4 dashboard notification (
EnhancedConversionsNotification) - Ads dashboard notification (
EnhancedConversionsNotification) - Analytics-4 settings notice (
EnhancedConversionsSettingsNotice) - Ads settings notice (
EnhancedConversionsSettingsNotice)
Bug Bashing Asana ticket for reference.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- The "Learn more" link in the Analytics-4 Enhanced Conversions dashboard notification displays the external link indicator.
- The "Learn more" link in the Ads Enhanced Conversions dashboard notification displays the external link indicator.
- The "Learn more" link in the Analytics-4 Enhanced Conversions settings notice displays the external link indicator.
- The "Learn more" link in the Ads Enhanced Conversions settings notice displays the external link indicator.
Implementation Brief
- Remove
hideExternalIndicatorprop from theLearnMoreLinkcomponent inassets/js/modules/analytics-4/components/notifications/EnhancedConversionsNotification.js. - Remove
hideExternalIndicatorprop from theLearnMoreLinkcomponent inassets/js/modules/ads/components/notifications/EnhancedConversionsNotification.js. - Remove
hideExternalIndicatorprop from theLearnMoreLinkcomponent inassets/js/modules/analytics-4/components/settings/EnhancedConversionsSettingsNotice.js. - Remove
hideExternalIndicatorprop from theLearnMoreLinkcomponent inassets/js/modules/ads/components/settings/EnhancedConversionsSettingsNotice.js.
Test Coverage
- Update VRT to approve new images showing the external icon.
QA Brief
- Ensure the above notifications have an icon next to their "Learn more" links
- The Analytics notifications can be seen after a fresh install in both the splash screen and in the Analytics settings under "Connected Services"
- The Ads notifications can be seen after enabling the Ads service in both the splash screen and in the Ads settings under "Connected Services"
Changelog entry
- Add missing external icon to "Learn more" links in enhanced conversions notifications.
Metadata
Metadata
Assignees
Labels
P1Medium priorityMedium priorityTeam MIssues for Squad 2Issues for Squad 2Type: EnhancementImprovement of an existing featureImprovement of an existing feature