-
Notifications
You must be signed in to change notification settings - Fork 328
Closed
Labels
P0High priorityHigh priorityTeam MIssues for Squad 2Issues for Squad 2Type: BugSomething isn't workingSomething isn't working
Description
Bug Description
When landing on the Key Metrics Setup screen after setting up Google Analytics, a toast notice should appear at the bottom right of the screen with the text "Google Analytics was successfully set up". It's currently correctly rendered, but the newly added footer hides it.
Steps to reproduce
- Set up Site Kit with
setupFlowRefreshenabled - Complete the Analytics setup
- Upon landing on the Key Metrics Setup screen, notice that the expect toast notice is not visible
Screenshots
Additional Context
- PHP Version:
- OS: [e.g. iOS]
- Browser: [e.g. chrome, safari]
- Plugin Version: [e.g. 22]
- Device: [e.g. iPhone6]
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- When running through the steps to reproduce, the "Google Analytics was successfully set up" toast should appear on the Key Metrics setup screen.
Implementation Brief
- Update the
ToastNoticestyles inassets/sass/components/toast-notice/_googlesitekit-toast-notice.scss- Add a
z-index: 1
- Add a
- Update the footer styles in
assets/sass/components/user-input/googlesitekit-user-input-module.scss- Update the horizontal padding of
.googlesitekit-user-input__footerfrom28pxto23px
- Update the horizontal padding of
Test Coverage
- Inspect and update failing VRTs.
QA Brief
- Set up Site Kit with
setupFlowRefreshfeature flag enabled - Complete the Analytics setup
- When landing on the Key Metrics Setup screen, ensure that the "Google Analytics was successfully set up" toast notice is visible
Changelog entry
- Ensure the "Google Analytics was successfully set up" toast should appears on the Key Metrics setup screen in the new setup flow.
Metadata
Metadata
Assignees
Labels
P0High priorityHigh priorityTeam MIssues for Squad 2Issues for Squad 2Type: BugSomething isn't workingSomething isn't working