Feature Description

Following this discussion in Asana, we've decided to remove the show_progress property from the Proxy_GoogleAnalyticsAdminProvisionAccountTicketRequest instance and add it as a query parameter to the redirect URI instead.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The show_progress query parameter is added to the redirect URI sent to the service when creating an Analytics account.
• The show_progress property is no longer included in the Analytics account ticket provisioning request.

Implementation Brief

• In includes/Modules/Analytics_4/GoogleAnalyticsAdmin/Proxy_GoogleAnalyticsAdminProvisionAccountTicketRequest.php:
  • Remove the $show_progress instance property and its getter/setter accessor methods.
• In includes/Modules/Analytics_4.php:
  • Update the create-account-ticket endpoint handler:
    • If the setupFlowRefresh feature flag is enabled and showProgress has been included in the request data, add the show_progress query parameter with a truthy value to the redirect URI passed to $account_ticket_request->setRedirectUri().
    • Remove the call to $account_ticket_request->setShowProgress().

Test Coverage

• Update the tests for the create-account-ticket endpoint handler to reflect the above changes.

QA Brief

• Turn on the setupFlowRefresh feature flag.
• Using the new setup flow, choose to enable Analytics and set up Site Kit.
• At the Analytics setup step, choose to create a new Analytics account.
• Upon returning from the Terms & Conditions acceptance, verify that the URL includes showProgress=true, and the page has the progress segments.

Changelog entry

• Pass show_progress as a query parameter to the redirect URI rather than as a separate property when creating an Analytics account in the new setup flow.