-
Notifications
You must be signed in to change notification settings - Fork 328
Closed
Labels
P1Medium priorityMedium priorityPHPQA: EngRequires specialized QA by an engineerRequires specialized QA by an engineerTeam MIssues for Squad 2Issues for Squad 2Type: EnhancementImprovement of an existing featureImprovement of an existing feature
Description
Feature Description
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- The features request (
/site-management/features/) body should be extended to includeamp_modeas a string:primary,secondary, or (blank) for none
Implementation Brief
- Update
Google_Proxy::get_featuresto includeamp_modefromContext::get_amp_modein the request body as a string
Test Coverage
- Update test coverage for
Google_Proxy
QA Brief
- Configure HTTP proxy on your local machine following instructions in the engineering workflow doc and use mitmproxy or an equivalent tool to inspect requests.
- To force a new features request, delete the cached transient features data by running:
wp option delete _transient_googlesitekit_remote_features
- Then go to the SiteKit Dashboard to trigger the request.
- Review requests made to the service
/site-management/features/, in the bodyamp_modeshould be present. - Test the following scenarios:
- No AMP plugin installed:
amp_modeshould be an empty string"" - AMP plugin in Standard mode:
amp_modeshould be"primary" - AMP plugin in Transitional or Reader mode:
amp_modeshould be"secondary"
- No AMP plugin installed:
Changelog entry
- Include the current AMP mode in the request to get enabled features.
Metadata
Metadata
Assignees
Labels
P1Medium priorityMedium priorityPHPQA: EngRequires specialized QA by an engineerRequires specialized QA by an engineerTeam MIssues for Squad 2Issues for Squad 2Type: EnhancementImprovement of an existing featureImprovement of an existing feature