-
Notifications
You must be signed in to change notification settings - Fork 328
Closed
Labels
Module: AdSenseGoogle AdSense module related issuesGoogle AdSense module related issuesP1Medium priorityMedium priorityTeam SIssues for Squad 1Issues for Squad 1Type: EnhancementImprovement of an existing featureImprovement of an existing feature
Description
Bug Description
After refactoring AdSense alerts, the target property coming from the server alert is not correctly mapped to the CTA button. This should be fixed.
Steps to reproduce
- Connect Site Kit and AdSense using a google account that is linked to an AdSense property that has some outstanding alert message.
- Click on the CTA button.
- The AdSense Admin dashboard opens in the same tab instead of a new tab.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- The
targetproperty coming from the Server Notification is correctly applied to the CTA of the Banner Notification. - In effect, clicking on the
Go to AdSenseCTA that appears on AdSense alerts navigates to the AdSense admin dashboard in a new tab.
Implementation Brief
- In
assets/js/components/Banner/CTAButton.js, add support for a newexternalprop as implemented inassets/js/components/Notice/CTAButton.js, including the trailing external icon functionality. - In
assets/js/components/NotificationFromServer.js, if thectaTargetproperty is_blank, then pass theexternalprop toctaButton.
Test Coverage
- Update VRTs but no other tests required.
QA Brief
- Follow the steps to reproduce and verify that the AdSense CTA now opens the AdSense dashboard in a new tab.
- Smoke test a few more Banner Notifications (e.g. Setup Banners like RRM / SiwG / Audience Segmentation + Gathering / Zero states) and Notice Notifications (any setup success notification for module / Site kit setup + any purple "new" notice like the "Auto updates CTA" that appears 10 mins after setting up new site using Site kit)
Changelog entry
- AdSense alert links now open in a new tab.
Metadata
Metadata
Assignees
Labels
Module: AdSenseGoogle AdSense module related issuesGoogle AdSense module related issuesP1Medium priorityMedium priorityTeam SIssues for Squad 1Issues for Squad 1Type: EnhancementImprovement of an existing featureImprovement of an existing feature