-
Notifications
You must be signed in to change notification settings - Fork 328
Closed
Labels
Module: Sign in with GoogleSign in with Google (SiwG) related issues.Sign in with Google (SiwG) related issues.P2Low priorityLow priorityTeam SIssues for Squad 1Issues for Squad 1Type: BugSomething isn't workingSomething isn't working
Description
Bug Description
-
On desktop, when the window occupies the whole screen, there is actually a big white gap in the SiwG module (edit screen):
-
Now notice that when I decreased the length of the window (resized it horizontally), the white gap is vanished as per attached image. I have attached a video as well (view as from 28 seconds).
-
It doesn't make sense why the gap is there on full screen. To me, it's best if we remove it. It will be visually better IMO.
Steps to reproduce
- Set up SK with SiwG
- Go to Settings > SiwG module > Edit screen
- Resize the window horizontally (full screen vs smaller desktop breakpoint)
- Notice the gap on full screen mode but not on a reduced desktop breakpoint.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- The gap between the Sign in with Google client ID and the button styling options should not be so excessive on larger viewports; it should look like this:
Implementation Brief
- Remove the CSS at , or make sure it isn't in use on larger viewports if it's needed on smaller viewports.
Lines 97 to 101 in a36928e
.mdc-layout-grid { .mdc-layout-grid__inner { margin-bottom: $grid-gap-desktop; } }
Test Coverage
- No new tests needed.
QA Brief
- Test the SiwG Settings screen on all view ports.
- Verify the spacing is improved on large viewports below the Client ID field.
- Verify spacing is reduced between the One Tap and Show for comments toggles.
Changelog entry
- Amend styles for Sign in with Google settings editing screen.
Metadata
Metadata
Assignees
Labels
Module: Sign in with GoogleSign in with Google (SiwG) related issues.Sign in with Google (SiwG) related issues.P2Low priorityLow priorityTeam SIssues for Squad 1Issues for Squad 1Type: BugSomething isn't workingSomething isn't working

