Feature Description
Now that the Ads Conversion ID setting has been fully migrated from the Analytics module to the Ads module, even with the Ads Conversion ID migration settings notice removed in #10430, we should entirely remove the Ads Conversion ID information from Analytics SettingsView, as it is quite guaranteed that this will no longer appear for users due to the automatic migration (see Core\Util\Migration_1_129_0).
We should also remove the Analytics adsConversionIDMigratedAtMs setting entirely as it is no longer used (I believe it was originally introduced to show the Ads Conversion ID migration settings notice which has been removed).
I believe we will have to preserve the Analytics adsConversionID setting as that is used to operate the migration (see Core\Util\Migration_1_129_0).
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- The Ads Conversion ID should no longer be displayed in the Analytics module's
SettingsView.
- The Ads Conversion ID should no longer be displayed in the Analytics module site health info
- The
adsConversionIDMigratedAtMs setting in the Analytics module should be removed entirely:
- It should no longer be stored or returned in selectors, settings, or REST responses.
- Any related logic, references, or code paths using
adsConversionIDMigratedAtMs should be removed.
- The
adsConversionID setting in the Analytics module should be preserved (as it is still required for the migration logic in Core\Util\Migration_1_129_0).
- But
adsConversionIDMigratedAtMs can be removed
Implementation Brief
Test Coverage
- Update Analytics 4 settings defaults assertions to remove
adsConversionIDMigratedAtMs (e.g., tests/phpunit/integration/Modules/Analytics_4/SettingsTest.php, and tests/phpunit/integration/Modules/Analytics_4Test.php where defaults are asserted).
- Remove any test expectations or imports for
getAdsConversionIDMigratedAtMs (none found beyond the settings view).
- If there are component tests for the Analytics settings view that snapshot the section with “Ads Conversion ID”, update/remove those snapshots accordingly.
QA Brief
- Set up Site Kit using version 1.175.0, including Analytics and Ads modules.
- Upgrade to the latest
develop branch using the tester plugin.
- No error should be observed during the "upgrade".
- Check Analytics settings in Site Kit:
- No errors should be observed.
- No mention of Ads Conversion ID should exist in Analytics. Ads Conversion ID should not be in Analytics settings.
Changelog entry
- Remove Ads Conversion ID entirely from Analytics module.
Feature Description
Now that the Ads Conversion ID setting has been fully migrated from the Analytics module to the Ads module, even with the Ads Conversion ID migration settings notice removed in #10430, we should entirely remove the Ads Conversion ID information from Analytics SettingsView, as it is quite guaranteed that this will no longer appear for users due to the automatic migration (see
Core\Util\Migration_1_129_0).We should also remove the Analytics
adsConversionIDMigratedAtMssetting entirely as it is no longer used (I believe it was originally introduced to show the Ads Conversion ID migration settings notice which has been removed).I believe we will have to preserve the Analytics
adsConversionIDsetting as that is used to operate the migration (seeCore\Util\Migration_1_129_0).Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
SettingsView.adsConversionIDMigratedAtMssetting in the Analytics module should be removed entirely:adsConversionIDMigratedAtMsshould be removed.adsConversionIDsetting in the Analytics module should be preserved (as it is still required for the migration logic inCore\Util\Migration_1_129_0).adsConversionIDMigratedAtMscan be removedImplementation Brief
assets/js/modules/analytics-4/components/settings/SettingsView.jsby deleting the block inOptionalSettingsViewthat renders it and its supporting selector usage.assets/js/modules/analytics-4/datastore/base.js, remove theadsConversionIDandadsConversionIDMigratedAtMssetting fromsettingSlugsGoogle\Site_Kit\Modules\Analytics_4\Settings:adsConversionIDMigratedAtMsfrom defaults and from the sanitize callback.Migration_1_168_0or whatever the release number is) that removesadsConversionIDMigratedAtMsfrom Analytics settings if present. Register it alongside existing migrations. LeaveMigration_1_129_0untouched.adsConversionIDMigratedAtMsfor conditional display or logic in JS or PHP after removal.Test Coverage
adsConversionIDMigratedAtMs(e.g.,tests/phpunit/integration/Modules/Analytics_4/SettingsTest.php, andtests/phpunit/integration/Modules/Analytics_4Test.phpwhere defaults are asserted).getAdsConversionIDMigratedAtMs(none found beyond the settings view).QA Brief
developbranch using the tester plugin.Changelog entry