-
Notifications
You must be signed in to change notification settings - Fork 330
Closed
Labels
P0High priorityHigh priorityTeam MIssues for Squad 2Issues for Squad 2Type: EnhancementImprovement of an existing featureImprovement of an existing feature
Description
Feature Description
All links to external Google services in Site Kit should have a utm_source parameter added, similar to the one done for Reader Revenue Manager.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- Any navigation to external Google services from Site Kit should include a
utm_sourcequery parameter withsitekitas the value.
Implementation Brief
- In
assets/js/googlesitekit/datastore/user/user-info.js:- Update the
getAccountChooserURLselector:- Before returning the final URL, use
addQueryArgto add autm_sourcequery parameter withsitekitas the value to thedestinationURL. - In the URL finally returned, add an additional
utm_sourcequery parameter withsitekitas the value.
- Before returning the final URL, use
- Update the
- In
assets/js/modules/pagespeed-insights/datastore/service.js:- Update the
getServiceURLselector to include autm_sourcequery parameter withsitekitas the value. UsegetServiceURLinassets/js/modules/reader-revenue-manager/datastore/service.jsas an example.
- Update the
Test Coverage
- In
assets/js/googlesitekit/datastore/user/user-info.test.js:- Update test coverage for
getAccountChooserURLto verify that theutm_sourceparameter exists in both wrapped and wrapper URLs.
- Update test coverage for
- In
assets/js/modules/pagespeed-insights/datastore/service.test.js:- Update test coverage for
getServiceURLto verify that theutm_sourceparameter exists.
- Update test coverage for
- Fix any other failing test.
QA Brief
- When navigating to any external service from Site Kit, verify that the resulting URL includes
utm_source=sitekitas a query parameter. - Some usual locations where such navigation occurs are:
- The source URLs in the SK dashboard widgets.
- "See full details in {service}" URLs in SK settings.
Changelog entry
- Add
utm_source=sitekitquery parameter to all external service links for source tracking.
Metadata
Metadata
Assignees
Labels
P0High priorityHigh priorityTeam MIssues for Squad 2Issues for Squad 2Type: EnhancementImprovement of an existing featureImprovement of an existing feature