Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ads setup CTA banner should show over audience segmentation not in parallel with it #10290

Closed
1 task done
zutigrm opened this issue Feb 28, 2025 · 2 comments
Closed
1 task done

Ads setup CTA banner should show over audience segmentation not in parallel with it #10290

zutigrm opened this issue Feb 28, 2025 · 2 comments
Labels
P1 Medium priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature

Comments

@zutigrm
Copy link
Collaborator

zutigrm commented Feb 28, 2025 •
edited by eugene-manuilov
Loading

Feature Description

Ads setup banner should go to the setup CTA queue with priority 9

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • When Analytics is connected and Ads is not, on dashboard only one of (Ads setup banner and Audience segmentation) CTA banner should be shown - with Ads setup one having the priority over audience segmentation banner

Implementation Brief

  • In assets/js/modules/ads/index.js
    • For ads-setup-cta, update the priority to 9 and include groupID property with a value of NOTIFICATION_GROUPS.SETUP_CTAS

Test Coverage

  • Not needed

QA Brief

  • Setup Site Kit with Analytics module and adsPax feature flag enabled
  • Verify that Ads setup banner is showing on dashboard (and audience segmentation is not)
  • Audience segmentation is showing only if Ads banner has been dismissed or does not fulfil condition to be shown - like Ads being connected

Changelog entry

  • Update the Ads setup CTA banner to appear before the Audience Segmentation banner.
@zutigrm zutigrm self-assigned this Feb 28, 2025
@zutigrm zutigrm added P1 Medium priority Type: Enhancement Improvement of an existing feature Team S Issues for Squad 1 labels Feb 28, 2025
@zutigrm zutigrm removed their assignment Feb 28, 2025
@10upsimon 10upsimon self-assigned this Feb 28, 2025
@10upsimon
Copy link
Collaborator

@zutigrm AC & IB ✅ Moving to EB.

@10upsimon 10upsimon assigned zutigrm and unassigned 10upsimon Feb 28, 2025
@zutigrm zutigrm mentioned this issue Feb 28, 2025
Merged
19 tasks
@zutigrm zutigrm removed their assignment Feb 28, 2025
@kelvinballoo kelvinballoo self-assigned this Mar 3, 2025
@kelvinballoo
Copy link
Collaborator

QA Update ✅

Tested as follows:

  • When Analytics is connected and Ads is not, Ads setup banner will show up first.

    • If Ads setup banner is dismissed, the Audience Segmentation banner is shown.
    • This is expected in terms of hierarchy as Ads setup has the priority over audience segmentation banner.
    10290.-.02.ads.cta.dismissed.and.AS.shows.ups.mov

  • If Ads module is connected, the Audience Segmentation banner will then show up.

    10290.-.03.ads.connected.and.AS.shows.ups.mov

@kelvinballoo kelvinballoo removed their assignment Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 Medium priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tofumatt @eugene-manuilov @zutigrm @10upsimon @kelvinballoo