Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console error when conversionReporting flag is enabled and analytics module is not connected #10289

Closed
1 task done
zutigrm opened this issue Feb 28, 2025 · 2 comments
Closed
1 task done
Labels
P1 Medium priority Team S Issues for Squad 1 Type: Bug Something isn't working

Comments

@zutigrm
Copy link
Collaborator

zutigrm commented Feb 28, 2025

Feature Description

When analytics is not setup and conversionReporting feature flag is enabled there is a console error


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • When conversionReporting feature flag is enabled, and Analytics module is not connected, there are no errors in the console

Implementation Brief

Test Coverage

  • Not needed

QA Brief

  • Setup Site Kit with conversionReporting feature flag
  • Do not install Analytics
  • Go to dashboard - verify there are no errors in console

Changelog entry

  • Fix the console error that appears when the conversionReporting flag is enabled and the Analytics module is not connected.
@zutigrm zutigrm self-assigned this Feb 28, 2025
@zutigrm zutigrm added Type: Bug Something isn't working P1 Medium priority Team S Issues for Squad 1 labels Feb 28, 2025
@zutigrm zutigrm removed their assignment Feb 28, 2025
@10upsimon 10upsimon self-assigned this Feb 28, 2025
@10upsimon
Copy link
Collaborator

@zutigrm AC and IB LGTM ✅ moving to EB with you.

@10upsimon 10upsimon assigned zutigrm and unassigned 10upsimon Feb 28, 2025
@zutigrm zutigrm mentioned this issue Feb 28, 2025
19 tasks
@zutigrm zutigrm removed their assignment Feb 28, 2025
@zutigrm zutigrm assigned eugene-manuilov and unassigned zutigrm Mar 3, 2025
@zutigrm zutigrm assigned eugene-manuilov and unassigned zutigrm Mar 4, 2025
@eugene-manuilov eugene-manuilov removed their assignment Mar 4, 2025
@kelvinballoo kelvinballoo self-assigned this Mar 4, 2025
@kelvinballoo
Copy link
Collaborator

QA Update ✅

Verified and the console error is no longer appearing in the develop branch.

10289.-.test.ok.mov

@kelvinballoo kelvinballoo removed their assignment Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Team S Issues for Squad 1 Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants