-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creation of Subtle Notification component for Existing Google for WooCommerce Ads Users #10176
Comments
Thanks @10upsimon , I did small updated on the sentence around replacing the content of setup CTA for clarification AC ✅ |
@zutigrm made some minor tweaks to location, file and component name, but aside from that LGTM, moving to EB ✅ |
QA Update ⚠
Question - @zutigrm When a user clicks on the 'Create New Account' CTA, there is a delay before the page starts loading. On a slow internet connection, it may seem like nothing is happening. To improve the user experience, we should add a loader that appears immediately after the user clicks the button. Let me know your thoughts! Recording.1837.mp4PASS CASES |
Thanks @mohitwp , fair point, I will add loader |
QA Update ✅
|
Feature Description
For users who have WooCommerce and Google for WooCommerce active and who already have an Ads account linked via Google for WooCommerce, a more subtle notification should be shown as opposed to the full Ads Module Setup CTA Banner. This is given the fact that there is - generally speaking - little to no value for the user to set up Ads in Site Kit as well.
The user will, however, still have the option of continuing to set up Ads in Site Kit should they still wish to, the CTA will simply be a little less bold and prominent than the Ads Module Setup CTA Banner.
To achieve this, a new notice subtle component that utilises the subtle notification style should be created within the Ads code space. The existing
<SubtleNotification>
can and should be used to support this new notice component. Said new subtle notification component should replace the contents of the Ads Module Setup CTA Banner when the following scenario is encountered:Figma designs can be found here.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
adsPax
feature flag is enabledImplementation Brief
assets/js/modules/ads/components/notifications/AccountLinkedViaGoogleForWooCommerceSubtleNotification.js
for creation of a new<AccountLinkedViaGoogleForWooCommerceSubtleNotification>
notification component.assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSegmentationSetupSuccessSubtleNotification.js
for an exampleid
andNotification
props, leveraging the new Notifications API infrastructureNotification
componentSubtleNotification
component for layout (notifications/components/layout/SubtleNotification
)IncludeSetstar-fill.svg
SVG icon and pass it asicon
propnew-feature
for thetype
propdescription
propCreate new account
asadditionalCTA
prop, passingCTALinkSubtle
component to build the buttonNo, thanks
secondary CTA asdismissCTA
prop and pass theDismiss
component to build the dismiss CTA. This will handle the dismissal logic in the background as well.useActivateModuleCallback
hook withads
passed as parameterassets/js/modules/ads/index.js
AccountLinkedViaGoogleForWooCommerceSubtleNotification
notification underregisterNotifications
function, together with other notification, and you can use default10
priority here as wellNOTIFICATION_AREAS.BANNERS_BELOW_NAV
forareaSlug
VIEW_CONTEXT_MAIN_DASHBOARD
forviewContexts
checkRequirements
, the notification should show if following selectors added in Create New Ads Module Datastore Partial for Plugin Detection Selectors #10170 are all true:isWooCommerceActive
isGoogleForWooCommerceActive
isGoogleForWooCommerceAdsAccountLinked
isDismissible
property with value oftrue
featureFlag
property with value ofadsPax
assets/sass/components/ads/_googlesitekit-account-linked-via-google-for-woocommerce-subtle-notification.scss
Test Coverage
AccountLinkedViaGoogleForWooCommerceSubtleNotification
componentAccountLinkedViaGoogleForWooCommerceSubtleNotification
componentQA Brief
adsPax
feature flag enabledCreate new account
CTA should navigate to the Ads module setup screenChangelog entry
The text was updated successfully, but these errors were encountered: