Feature Description

Issue 2/3 to fix the bug #8888.

Add the new audience settings store, but don't integrate it into the Analytics store. Write tests just for the store slice.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• Datastore actions and selectors should be added for getting and saving the new audience settings (see Add the new Audience_Settings class and datapoints. #10153).
• These can be defined in a new store slice, with the slice itself being integrated into the full store via the subsequent/parent issue Syncing audiences and custom dimensions in parallel can result in the cached audiences not being persisted #8888.

Implementation Brief

Create isolated, tested, audiences settings store.

Note: this ticket should not integrate this settings store into the analytics module, this work will be done in #8888.

• Update assets/js/googlesitekit/datastore/user/audience-settings.js:

  • Update the name of these selectors and actions where they are defined:
    • getAudienceSettings to getUserAudienceSettings
    • saveAudienceSettings to saveUserAudienceSettings
    • resetAudienceSettings to resetUserAudienceSettings
    • isSavingAudienceSettings to isSavingUserAudienceSettings

• Update the name of these selectors and actions everywhere they are used in the current codebase.

• Create a new store file assets/js/modules/analytics-4/datastore/audience-settings.js:

  • Implement a new fetch store using createFetchStore:
    • The controlCallback should use API.get to send GET requests to GET:audience-settings.
    • Implement a resolver and the following selectors to get fetching from this endpoint:
      • getAvailableAudiences *Note: the original, duplicate, definition of getAvailableAudiences will be removed from assets/js/modules/analytics-4/datastore/audiences.js when this work is combined in Syncing audiences and custom dimensions in parallel can result in the cached audiences not being persisted #8888.
      • getAudienceSegmentationSetupCompletedBy
  • Implement a new fetch store using createFetchStore:
    • The controlCallback should use API.set to send POST requests to POST:save-audience-settings.
      • Implement new setAvailableAudiences, setAudienceSegmentationSetupCompletedBy and saveAudienceSettings actions.

Test Coverage

• Create thorough tests for this new settings store.

QA Brief

• This issue doesn't register the store, so it does not make any user facing difference. A round of smoke testing for Audience Segmentation should be enough to make sure things are intact.
• The changes introduced here will be integrated and fully tested in Syncing audiences and custom dimensions in parallel can result in the cached audiences not being persisted #8888.

Changelog entry

• Add a datastore slice with actions and selectors for retrieving and updating the new set of audience settings.