-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RRM product ID setting #10065
Comments
The AC does raise the same question about what to do with a stale product ID when changing the publication in the dropdown as discussed in #9953 (comment), but I think we can address that in #9953 (or, maybe it will be covered in the IB for this issue anyway if it gets specced first). AC ✅ |
@techanvil Just FYI, I've added two new ACs as follows:
I had missed them earlier, my apologies. Thank you! CC: @hussain-t |
Hi @nfmohit, the AC mentions integrating the dropdown only in the settings edit screen. However, it should also be included on the setup screen as well. Do we have another issue with implementing the setup screen, or did the AC overlook it? Thanks! |
@hussain-t Good catch. I indeed overlooked it in the ACs. I've updated the ACs to include that:
CC: @techanvil |
@nfmohit, as we discussed, the warning notification next to the product ID dropdown should now be permanently dismissible. I’ve updated the IB to reflect this. Could you please update the AC accordingly while reviewing the IB? Thank you!
|
Thank you @hussain-t! I've updated the ACs accordingly, as discussed, specifically the following:
I've changed the dismissal to be persistent to simplify it, as a session-based temporary dismissal wasn't a design requirement. Thanks! CC: @techanvil |
IB LGTM ✅ Nice work, @hussain-t! Just a note that I've updated the IB to explicitly mention that the product ID should only be auto-selected once on page load.
Thanks! |
Moved this to Merge Review as I've made a bunch of changes to the PR during CR, in Hussain's absence. Thanks! |
…id-settings Enhancement/#10065 - Add RRM product ID setting
QA Update ❌
Issue 1: The dismissible informational subtle notification, placed below the dropdown with the text 'Use the new settings in the block editor to select different product IDs for individual pages or control where CTAs appear on an individual post. Learn more', moves beside the dropdown on large viewports with a width of 1714px or more. Issue 2: Default product ID text field is not properly aligned under RRM settings view. PASS CASES |
This actually falls under the scope of #10067, and it has been mentioned in the QAB that the alignment will not be correct. We'll address the alignment across all modules as part of a new epic/set of issues. Thanks! |
…id-info-notice-width Enhancement/#10065 - Fix product id info notice width (follow-up)
Hi @mohitwp. The follow-up PR has been merged with a fix for Issue 1, and this is now back to you for another round. Thanks! |
QA Update ✅
|
Feature Description
A dropdown (and associated informational elements) should be added to the Reader Revenue Manager setup and settings to aid the selection of a product ID.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
openaccess
.rrmModuleV2
feature flag is enabled, the dropdown should be added as a required field according to the Figma designs.rrmModuleV2
feature flag is enabled and the selected publication has available product IDs:rrmModuleV2
feature flag is enabled and the selected publication has available product IDs or there is a saved product ID:rrm-content-settings
support redirector in a new tab. Note that it hasn't been added to the Support Redirects sheet yet, and the link, for now, will direct to a 404 page.Implementation Brief
Create a
ProductIDSelect
Componentassets/js/modules/reader-revenue-manager/components/common
, create a newProductIDSelect
component with the following:getProductIDs()
selector of the Reader Revenue Manager store.ProgressBar
component if product IDs are still resolving.openaccess
) as the first static option in the dropdown.setProductID
action.Select
,Option
components with the necessary props.onEnhancedChange
prop of theSelect
component.Integrate
ProductIDSelect
into the RRM Setup Flowassets/js/modules/reader-revenue-manager/components/setup/SetupForm.js
:ProductIDSelect
component next to the publication dropdown if:rrmModuleV2
feature flag is enabled.productID
is empty oropenaccess
) and there is at least one custom product ID using thegetProductIDs
selector.setProductID( firstCustomProductID )
to select the first non-openaccess
product ID by default using theuseEffect
hook.Integrate
ProductIDSelect
to the RRM Settings Edit Screenassets/js/modules/reader-revenue-manager/components/settings/SettingsEdit.js
:ProductIDSelect
component below the publication dropdown if:rrmModuleV2
feature flag is enabled.paymentOption
issubscriptions
using thegetPaymentOption
selector and the user selects “Open access,”, render theSubleNotification
component with the following:variant
:warning
description
:Selecting “Open access” will allow your reader to access your content without a subscription
dismissLabel
:Got it
onDismiss
: pass a callback function that dispatches thedismissItem
action to dismiss the notification permanently.SubleNotification
component with the following:variant
:info
description
:Use the new settings in the block editor to select different product IDs for individual pages or control where CTAs appear on an individual post. You can also configure a different product ID for a group of posts in the Categories or Tags section. Learn more
dismissLabel
:Got it
onDismiss
: pass a callback function that dispatches thedismissItem
action to dismiss the notification permanently.Modify
SubtleNotification
Componentassets/js/components/notifications/SubtleNotification.js
:VARIANTS
constants to add a new propertyINFO
with the valueinfo
.googlesitekit-subtle-notification
parent element and add a conditional classgooglesitekit-subtle-notification--info
if the variant isinfo
.googlesitekit-subtle-notification__icon
element and render theinfo-circle.svg
icon if the variant isinfo
.info
variant inassets/sass/components/dashboard/_googlesitekit-subtle-notification.scss
.Test Coverage
ProductIDSelect
component.SetupForm
andSettingsEdit
components to showcase theProductIDSelect
in various states.ProductIDSelect
component.SetupForm
andSettingsEdit
components.QA Brief
rrmModuleV2
feature flag enabled.ProductIDSelect
dropdown is displayed in the setup flow as per the ACs.Open access
product ID is auto-selected during setup if the user hasn't selected a product ID yet.ProductIDSelect
dropdown is displayed in the settings edit screen as per the ACs.Changelog entry
The text was updated successfully, but these errors were encountered: