Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/re2
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2024-04-01
Choose a base ref
...
head repository: google/re2
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2024-05-01
Choose a head ref
  • 8 commits
  • 11 files changed
  • 1 contributor

Commits on Apr 8, 2024

  1. Stop setting re2_INCLUDE_DIR.

    It was probably neither needed nor used and will start causing
    problems as of CMake 3.29, which removes `PACKAGE_PREFIX_DIR`.
    
    Fixes #488.
    
    Change-Id: I707dc903234309698a6745d2b61279fd3b7bd6dc
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62930
    Reviewed-by: Paul Wankadia <[email protected]>
    Reviewed-by: Alex Chernyakhovsky <[email protected]>
    junyer committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    9ebe4a2 View commit details
    Browse the repository at this point in the history
  2. Bump some versions in MODULE.bazel.

    Change-Id: I528b54aa604dcca48a915c8d87a23d7cbbe10659
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62950
    Reviewed-by: Jashank Jeremy <[email protected]>
    Reviewed-by: Paul Wankadia <[email protected]>
    junyer committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    4f6f815 View commit details
    Browse the repository at this point in the history
  3. Add a GitHub Actions workflow for releases.

    Triggering off a pushed tag, it creates the corresponding release, then
    downloads the source code archives and uploads them as release assets
    using Sigstore for signature. Someday, it will be convenient to switch
    to using SLSA for signature and provenance, but that day is not today.
    
    Yours truly has been wanting to automate away this dance for years. In
    light of CVE-2024-3094, now seemed like a really good time to do that.
    
    Change-Id: I0972ae5dcae7193ef457e23553a7dbe22adbfb1c
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62970
    Reviewed-by: Ash Liu <[email protected]>
    Reviewed-by: Paul Wankadia <[email protected]>
    junyer committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    b0e6423 View commit details
    Browse the repository at this point in the history
  4. Fix the Sigstore inputs. Sigh.

    Change-Id: I5ee5e77240952d4927959e2cdbe1b2f82cfa4d92
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62971
    Reviewed-by: Paul Wankadia <[email protected]>
    Reviewed-by: Ash Liu <[email protected]>
    junyer committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    e76b306 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Switch to PyPI publishing via a trusted publisher.

    Change-Id: Ie94c5e6931f8fa70f238c9a5360874ff8833876a
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62972
    Reviewed-by: Perry Lorier <[email protected]>
    Reviewed-by: Paul Wankadia <[email protected]>
    junyer committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    3c7e162 View commit details
    Browse the repository at this point in the history
  2. Bring back .YYYYMMDD suffixes for google-re2 versioning.

    While I'm here, update @abseil-cpp to version 20240116.2.
    
    Fixes #486.
    
    Change-Id: I86ec3bd1860e2bd1424a67eb5590eaaa7cc4ea71
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/62990
    Reviewed-by: Paul Wankadia <[email protected]>
    Reviewed-by: Alex Chernyakhovsky <[email protected]>
    junyer committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    b84e3ff View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Prepare to tag release 2024-05-01.

    Bump versions of actions and dependencies.
    
    Change-Id: Ifb798e7c320b092e2faed2cd4d03fc962b8c009e
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/63010
    Reviewed-by: Alex Chernyakhovsky <[email protected]>
    Reviewed-by: Paul Wankadia <[email protected]>
    junyer committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    fbb52d9 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Use pkg-config to find GoogleTest and Benchmark.

    The GNU make CI workflow is currently broken on macOS because the Homebrew
    prefix differs between X64 and ARM64. It turns out that the compiler can't
    find GoogleTest (and Benchmark) anymore via the default path(s). We should
    really have been specifying the path(s) explicitly long before now anyway.
    
    Change-Id: If526389aa89b20b64ccfcc486769050c351e759f
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/63030
    Reviewed-by: Paul Wankadia <[email protected]>
    Reviewed-by: Alex Chernyakhovsky <[email protected]>
    junyer committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    2b354c6 View commit details
    Browse the repository at this point in the history
Loading