Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/re2
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2024-03-01
Choose a base ref
...
head repository: google/re2
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2024-04-01
Choose a head ref
  • 15 commits
  • 21 files changed
  • 3 contributors

Commits on Mar 4, 2024

  1. Update @pybind11_bazel to version 2.11.1.bzl.3. 

    At long last, we can test the Python bindings in the CI
because they should actually work on Windows as well...

Change-Id: Iede307a2cc059fd3230d238e0861439971b4169f
Reviewed-on: https://code-review.googlesource.com/c/re2/+/62751
Reviewed-by: Perry Lorier <[email protected]>
Reviewed-by: Paul Wankadia <[email protected]>
    @junyer
    junyer committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    45c9985 View commit details
    Browse the repository at this point in the history

  2. Disable MSYS/MSYS2 path conversion, which interferes with Bazel. 

    Change-Id: I0a0966667baf39310eba885078b99200612e014e
Reviewed-on: https://code-review.googlesource.com/c/re2/+/62790
Reviewed-by: Perry Lorier <[email protected]>
Reviewed-by: Paul Wankadia <[email protected]>
    @junyer
    junyer committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    8695a63 View commit details
    Browse the repository at this point in the history

  3. Use try-import to load an optional user-specific user.bazelrc 

    This is very useful for setting local configurations such as
extra warnings, --config, etc.

Name `user.bazelrc` like bazel best practices describe it:
https://bazel.build/configure/best-practices#bazelrc-file

Change-Id: If531d682668b4cb2421cfba79848102964634189
Reviewed-on: https://code-review.googlesource.com/c/re2/+/62770
Reviewed-by: Paul Wankadia <[email protected]>
Reviewed-by: Alex Chernyakhovsky <[email protected]>
    @hzeller @junyer
    hzeller authored and junyer committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    dbf15a2 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Delete an old comment. 

    Change-Id: Iafd06023ceaf5023a99a0d54be846d6ae8ab1035
Reviewed-on: https://code-review.googlesource.com/c/re2/+/62810
Reviewed-by: Alex Chernyakhovsky <[email protected]>
Reviewed-by: Paul Wankadia <[email protected]>
    @junyer
    junyer committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    27536b0 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Add Clang 18 to the build matrix. 

    ... and remove Clang 15 so that we continue to
test with only the three most recent releases.

Change-Id: Ib1eaa20b2c988bb53027dd3e01551d5d95058e24
Reviewed-on: https://code-review.googlesource.com/c/re2/+/62830
Reviewed-by: Perry Lorier <[email protected]>
Reviewed-by: Paul Wankadia <[email protected]>
    @junyer
    junyer committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    ddb3414 View commit details
    Browse the repository at this point in the history

  2. p0deje/setup-bazel has been transferred to bazel-contrib. 

    While I'm here, update to the latest release.

Change-Id: I785222dc8afb9b5fec838261c632f81bb24ab48c
Reviewed-on: https://code-review.googlesource.com/c/re2/+/62831
Reviewed-by: Perry Lorier <[email protected]>
Reviewed-by: Paul Wankadia <[email protected]>
    @junyer
    junyer committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    108914d View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. doc/mksyntaxgo: use standard generated Go header 

    Change generated commment to follow https://go.dev/s/generatedcode

Change-Id: I61e0da6583a5f8df2da63d669388cce83ad91d0d
Reviewed-on: https://code-review.googlesource.com/c/re2/+/62850
Reviewed-by: Paul Wankadia <[email protected]>
Reviewed-by: Alex Chernyakhovsky <[email protected]>
    @alexandear @junyer
    alexandear authored and junyer committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    58f6cdd View commit details
    Browse the repository at this point in the history

  2. Fix the link to the Python wrapper. 

    Change-Id: I9fdb4ce637857acb6d7c9979a910bf35db99fa75
Reviewed-on: https://code-review.googlesource.com/c/re2/+/62870
Reviewed-by: Alex Chernyakhovsky <[email protected]>
Reviewed-by: Paul Wankadia <[email protected]>
    @junyer
    junyer committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    5c5c8ed View commit details
    Browse the repository at this point in the history

  3. Bump versions of actions to latest releases. 

    Note that this isn't the same as pinning to commits as in specifying
their hashes. Note also that this isn't as ugly either. It's a minor
improvement over "floating" (i.e. major version only) tags/branches.

Change-Id: Id88fe81281885aff41f2625b3b71f945266c8677
Reviewed-on: https://code-review.googlesource.com/c/re2/+/62871
Reviewed-by: Alex Chernyakhovsky <[email protected]>
Reviewed-by: Paul Wankadia <[email protected]>
    @junyer
    junyer committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    db46d1e View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Raise re2.error instead of crashing. 

    Fixes #484.

Change-Id: I152b5ed8a6358d2d74f553bde2e66f2e50cfba1d
Reviewed-on: https://code-review.googlesource.com/c/re2/+/62890
Reviewed-by: Alex Chernyakhovsky <[email protected]>
Reviewed-by: Paul Wankadia <[email protected]>
    @junyer
    junyer committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    1250a99 View commit details
    Browse the repository at this point in the history

  2. Make compiling a no-op if it's attempted before adding any patterns. 

    Fixes #485.

Change-Id: Id7900ab2d034432016d425aeceb60a814225f10e
Reviewed-on: https://code-review.googlesource.com/c/re2/+/62872
Reviewed-by: Paul Wankadia <[email protected]>
Reviewed-by: Alex Chernyakhovsky <[email protected]>
    @junyer
    junyer committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    6598a8e View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Prepare to tag release 2024-04-01. 

    Change-Id: Ib26837e1d2d63ce13b1ef171c5c1af8168b94448
Reviewed-on: https://code-review.googlesource.com/c/re2/+/62910
Reviewed-by: Jeff Bailey <[email protected]>
Reviewed-by: Paul Wankadia <[email protected]>
    @junyer
    junyer committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    c0f9f17 View commit details
    Browse the repository at this point in the history

  2. Force a specific target version of macOS. 

    Otherwise, `delocate` renames the wheels!

Change-Id: I03bf330332a1586deed0519b7983b1a29574ec64
Reviewed-on: https://code-review.googlesource.com/c/re2/+/62911
Reviewed-by: Jeff Bailey <[email protected]>
Reviewed-by: Paul Wankadia <[email protected]>
    @junyer
    junyer committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    553f6df View commit details
    Browse the repository at this point in the history

  3. Tell Bazel the specific target version of macOS too. Sigh. 

    Change-Id: I4f50d5299a0462d279042a2175995fff00ff97e4
Reviewed-on: https://code-review.googlesource.com/c/re2/+/62912
Reviewed-by: Paul Wankadia <[email protected]>
Reviewed-by: Jeff Bailey <[email protected]>
    @junyer
    junyer committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    917047f View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Don't specify -pthread on Emscripten either. 

    Change-Id: I6b23bb04f0caaa2a65a23c941b1aea1eeb4da25d
Reviewed-on: https://code-review.googlesource.com/c/re2/+/62913
Reviewed-by: Ash Liu <[email protected]>
Reviewed-by: Paul Wankadia <[email protected]>
    @junyer
    junyer committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    ac82d4f View commit details
    Browse the repository at this point in the history
Loading