Skip to content

Google sync#1568

Merged
rchen152 merged 3 commits intomainfrom
google_sync
Jan 23, 2024
Merged

Google sync#1568
rchen152 merged 3 commits intomainfrom
google_sync

Conversation

@rchen152
Copy link
Copy Markdown
Contributor

No description provided.

…s.KW_ONLY.

* Respects KW_ONLY for dataclass attributes that don't use dataclasses.field.
* Removes unnecessary version check for applying kwonly-ness: it's impossible
  for a user to even set KW_ONLY or kw_only unless they're using a version
  where the field/parameter is available, so once it's been set, we can safely
  assume we're in a high-enough version.

PiperOrigin-RevId: 597970055
* Reports an [invalid-annotation] error when a TypedDict key has an ambiguous
  type.
* Simplifies some of the TypedDict code by assuming that keys have unambiguous
  types.

Fixes #1566.

PiperOrigin-RevId: 599320573
@rchen152 rchen152 merged commit c6869a1 into main Jan 23, 2024
@rchen152 rchen152 deleted the google_sync branch January 23, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant