Don't promote __init_subclass__ to a classmethod if it's already one.

rchen152 · rchen152 · commit 2707c42d15f1 · 2024-04-10T14:40:44.000-07:00
Fixes a crash in the release dashboard.

PiperOrigin-RevId: 623606336
diff --git a/pytype/overlays/special_builtins.py b/pytype/overlays/special_builtins.py
@@ -776,6 +776,8 @@ def call(self, node, func, args, alias_map=None):
     arg = args.posargs[0]
     if not _check_method_decorator_arg(arg, "classmethod", self.ctx):
       return node, self.ctx.new_unsolvable(node)
+    if any(isinstance(v, ClassMethodInstance) for v in arg.data):
+      return node, arg
     for d in arg.data:
       d.is_classmethod = True
       d.is_attribute_of_class = True
diff --git a/pytype/tests/test_classes2.py b/pytype/tests/test_classes2.py
@@ -593,6 +593,18 @@ def __init_subclass__(cls):
           super().__init_subclass__()
     """)
 
+  def test_init_subclass_explicit_classmethod(self):
+    ty = self.Infer("""
+      class Foo:
+        @classmethod
+        def __init_subclass__(cls):
+          pass
+    """)
+    self.assertTypesMatchPytd(ty, """
+      class Foo:
+        def __init_subclass__(cls) -> None: ...
+    """)
+
 
 if __name__ == "__main__":
   test_base.main()
