Move native_enum_type_map into internals and remove cross_extension_shared_states feature.
#30140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…()` with `get_internals().native_enum_type_map`
rwgk
changed the title
native_enum_type_map into internals and remove cross_extension_shared_states feature.native_enum_type_map into internals and remove cross_extension_shared_states feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Essentially this is rolling back #30008
Motivations:
Make it much easier to
git mergefrom upstream (pybind11masterorsmart_holder branch).Have a better starting point for [smart_holder] Conversions between Python's native (stdlib) enum types and C++ enums. pybind/pybind11#5280 (this was completed already).
Additional consideration:
Merging this PR now to start work on
git merge smart_holder.Suggested changelog entry: