Repository navigation
Remove invalid check in _FieldSet.writeFieldValue - #660
Merged
Merged
Conversation
A field value is one of these: - PbListBase (for `repeated`, PbList after #626) - PbMap - int - double - bool - String - List<int> (for `bytes`) - GeneratedMessage `ByteData` is not a valid field value type, so remove the `ByteData` cases when checking field value types.
sigurdm
approved these changes
May 24, 2022
sigurdm
left a comment
sigurdm
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Nice cleanup - am I understanding correctly that protobuf bytes are never stored as ByteData, but rather as a Uint8List backed by ByteData?
Contributor
Author
Protobuf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A field value is one of these:
repeated, PbList after Simplify PbList implementation, fix freezing #626)bytes)ByteDatais not a valid field value type, so remove theByteDatacases when checking field value types.
cl/450892812