Skip to content

Fix deprecated API usage in ToolsLocator#786

Merged
ejona86 merged 1 commit into
google:masterfrom
breskeby:fix-91-incompatibility
Sep 9, 2025
Merged

Fix deprecated API usage in ToolsLocator#786
ejona86 merged 1 commit into
google:masterfrom
breskeby:fix-91-incompatibility

Conversation

@breskeby

@breskeby breskeby commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

Gradle 9.1 deprecates declaring dependencies using multi-string notation.
Instead single-string notation should be used instead.

See https://docs.gradle.org/9.1.0-rc-2/userguide/upgrading_version_9.html#dependency_multi_string_notation for details.

This fixes the ToolLocator by using the prefered single-string notation now

@google-cla

google-cla Bot commented Sep 3, 2025

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@breskeby
breskeby force-pushed the fix-91-incompatibility branch 3 times, most recently from 7c412ae to 2726fcf Compare September 3, 2025 14:48
Gradle 9.1 deprecates declaring dependencies using multi-string notation.
Instead single-string notation should be used instead.
@breskeby
breskeby force-pushed the fix-91-incompatibility branch from 2726fcf to d66789b Compare September 3, 2025 14:51
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Sep 3, 2025
Temporary fix until the PR against the protobuf plugin at
google/protobuf-gradle-plugin#786
is merged.
@ejona86
ejona86 merged commit 894f2d2 into google:master Sep 9, 2025
11 checks passed
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Sep 16, 2025
Temporary fix until the PR against the protobuf plugin at
google/protobuf-gradle-plugin#786
is merged.
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Sep 18, 2025
Temporary fix until the PR against the protobuf plugin at
google/protobuf-gradle-plugin#786
is merged.
@breskeby

Copy link
Copy Markdown
Contributor Author

thanks for merging. are there any plans to run another release of this plugin that contains this PR anytime soon?

breskeby added a commit to breskeby/elasticsearch that referenced this pull request Sep 18, 2025
Temporary fix until the PR against the protobuf plugin at
google/protobuf-gradle-plugin#786
is merged.
breskeby added a commit to elastic/elasticsearch that referenced this pull request Sep 19, 2025
* WIP gradle 9.0 update

* Fix build integration tests
* Avoid usage of archives configuration
* Reference PR build for protobuf plugin

Temporary fix until the PR against the protobuf plugin at
google/protobuf-gradle-plugin#786
is merged.
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Sep 19, 2025
* WIP gradle 9.0 update

* Fix build integration tests
* Avoid usage of archives configuration
* Reference PR build for protobuf plugin

Temporary fix until the PR against the protobuf plugin at
google/protobuf-gradle-plugin#786
is merged.

(cherry picked from commit 71be643)

# Conflicts:
#	x-pack/plugin/otel-data/build.gradle
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Sep 19, 2025
* WIP gradle 9.0 update

* Fix build integration tests
* Avoid usage of archives configuration
* Reference PR build for protobuf plugin

Temporary fix until the PR against the protobuf plugin at
google/protobuf-gradle-plugin#786
is merged.

(cherry picked from commit 71be643)

# Conflicts:
#	build-tools-internal/src/main/resources/minimumGradleVersion
#	x-pack/plugin/otel-data/build.gradle
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Sep 19, 2025
* WIP gradle 9.0 update

* Fix build integration tests
* Avoid usage of archives configuration
* Reference PR build for protobuf plugin

Temporary fix until the PR against the protobuf plugin at
google/protobuf-gradle-plugin#786
is merged.

(cherry picked from commit 71be643)

# Conflicts:
#	build-tools-internal/src/main/resources/minimumGradleVersion
#	x-pack/plugin/otel-data/build.gradle
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Sep 19, 2025
* WIP gradle 9.0 update

* Fix build integration tests
* Avoid usage of archives configuration
* Reference PR build for protobuf plugin

Temporary fix until the PR against the protobuf plugin at
google/protobuf-gradle-plugin#786
is merged.

(cherry picked from commit 71be643)

# Conflicts:
#	build-tools-internal/src/main/resources/minimumGradleVersion
#	x-pack/plugin/otel-data/build.gradle
breskeby added a commit to elastic/elasticsearch that referenced this pull request Sep 19, 2025
* Update Gradle wrapper to 9.1.0 (#132970)

* WIP gradle 9.0 update

* Fix build integration tests
* Avoid usage of archives configuration
* Reference PR build for protobuf plugin

Temporary fix until the PR against the protobuf plugin at
google/protobuf-gradle-plugin#786
is merged.

(cherry picked from commit 71be643)

# Conflicts:
#	build-tools-internal/src/main/resources/minimumGradleVersion
#	x-pack/plugin/otel-data/build.gradle

* Delete config.js
breskeby added a commit to elastic/elasticsearch that referenced this pull request Sep 19, 2025
* Update Gradle wrapper to 9.1.0 (#132970)

* WIP gradle 9.0 update

* Fix build integration tests
* Avoid usage of archives configuration
* Reference PR build for protobuf plugin

Temporary fix until the PR against the protobuf plugin at
google/protobuf-gradle-plugin#786
is merged.

(cherry picked from commit 71be643)

# Conflicts:
#	build-tools-internal/src/main/resources/minimumGradleVersion
#	x-pack/plugin/otel-data/build.gradle

* Delete config.js
breskeby added a commit to elastic/elasticsearch that referenced this pull request Sep 19, 2025
* Update Gradle wrapper to 9.1.0 (#132970)

* WIP gradle 9.0 update

* Fix build integration tests
* Avoid usage of archives configuration
* Reference PR build for protobuf plugin

Temporary fix until the PR against the protobuf plugin at
google/protobuf-gradle-plugin#786
is merged.

(cherry picked from commit 71be643)

# Conflicts:
#	build-tools-internal/src/main/resources/minimumGradleVersion
#	x-pack/plugin/otel-data/build.gradle

* Delete config.js
breskeby added a commit to elastic/elasticsearch that referenced this pull request Sep 19, 2025
* Update Gradle wrapper to 9.1.0 (#132970)

* WIP gradle 9.0 update

* Fix build integration tests
* Avoid usage of archives configuration
* Reference PR build for protobuf plugin

Temporary fix until the PR against the protobuf plugin at
google/protobuf-gradle-plugin#786
is merged.

(cherry picked from commit 71be643)

# Conflicts:
#	x-pack/plugin/otel-data/build.gradle

* Delete config.js
@andrross

Copy link
Copy Markdown

@ejona86 I'm also interested in getting this fix into a release to avoid warnings when using Gradle 9.1. Is another release planned? I'm happy to help if there's anything I can do to help with the release.

@liutikas

Copy link
Copy Markdown
Contributor

@ejona86 could we release a new version of the plugin that has this fix?

@danishnawab

Copy link
Copy Markdown

Would appreciate a new release containing this change.

Can you please offer some transparency into when that might be?

@wjglerum

Copy link
Copy Markdown

Same here, any news on a new release?

@danishnawab

Copy link
Copy Markdown

@ejona86 any chance to get an ETA here?

@jjohannes

jjohannes commented Nov 14, 2025

Copy link
Copy Markdown

A new release to remove the deprecation warning with current Gradle versions would be highly appreciated.

Declaring dependencies using multi-string notation has been deprecated. This will fail with an error in Gradle 10. Please use single-string notation instead: "com.google.protobuf:protoc::osx-aarch_64@exe".

@nillpoe

nillpoe commented Dec 9, 2025

Copy link
Copy Markdown

Same here, eagerly waiting for the release

@autonomousapps

Copy link
Copy Markdown

Also chiming in to say that my team would love a release. Is it... hard to release a new version?

@marcphilipp

Copy link
Copy Markdown

We would also love to see this released. Is there anything anyone can do to help?

fressi-elastic added a commit to elastic/elasticsearch that referenced this pull request Jan 20, 2026
…0947)

This is a followup of #132970 after google/protobuf-gradle-plugin#786 has been merged.

It removes the dependency on a deleted snapshot build of the protobuf-gradle-plugin and updates to the official 0.9.6 release. The changes eliminate the temporary workaround that was needed for Java 9.1 compatibility.

Changes:

- Updated to official `protobuf-gradle-plugin` version 0.9.6
- Removed buildscript block with JitPack repository and snapshot dependency
breskeby pushed a commit to breskeby/elasticsearch that referenced this pull request Jan 20, 2026
…stic#140947)

This is a followup of elastic#132970 after google/protobuf-gradle-plugin#786 has been merged.

It removes the dependency on a deleted snapshot build of the protobuf-gradle-plugin and updates to the official 0.9.6 release. The changes eliminate the temporary workaround that was needed for Java 9.1 compatibility.

Changes:

- Updated to official `protobuf-gradle-plugin` version 0.9.6
- Removed buildscript block with JitPack repository and snapshot dependency

(cherry picked from commit d27f55f)
breskeby pushed a commit to breskeby/elasticsearch that referenced this pull request Jan 20, 2026
…stic#140947)

This is a followup of elastic#132970 after google/protobuf-gradle-plugin#786 has been merged.

It removes the dependency on a deleted snapshot build of the protobuf-gradle-plugin and updates to the official 0.9.6 release. The changes eliminate the temporary workaround that was needed for Java 9.1 compatibility.

Changes:

- Updated to official `protobuf-gradle-plugin` version 0.9.6
- Removed buildscript block with JitPack repository and snapshot dependency

(cherry picked from commit d27f55f)
breskeby added a commit to elastic/elasticsearch that referenced this pull request Jan 20, 2026
…0947) (#140985)

This is a followup of #132970 after google/protobuf-gradle-plugin#786 has been merged.

It removes the dependency on a deleted snapshot build of the protobuf-gradle-plugin and updates to the official 0.9.6 release. The changes eliminate the temporary workaround that was needed for Java 9.1 compatibility.

Changes:

- Updated to official `protobuf-gradle-plugin` version 0.9.6
- Removed buildscript block with JitPack repository and snapshot dependency

(cherry picked from commit d27f55f)

Co-authored-by: Federico Ressi <[email protected]>
breskeby added a commit to elastic/elasticsearch that referenced this pull request Jan 20, 2026
…0947) (#140983)

This is a followup of #132970 after google/protobuf-gradle-plugin#786 has been merged.

It removes the dependency on a deleted snapshot build of the protobuf-gradle-plugin and updates to the official 0.9.6 release. The changes eliminate the temporary workaround that was needed for Java 9.1 compatibility.

Changes:

- Updated to official `protobuf-gradle-plugin` version 0.9.6
- Removed buildscript block with JitPack repository and snapshot dependency

(cherry picked from commit d27f55f)

Co-authored-by: Federico Ressi <[email protected]>
spinscale pushed a commit to spinscale/elasticsearch that referenced this pull request Jan 21, 2026
…stic#140947)

This is a followup of elastic#132970 after google/protobuf-gradle-plugin#786 has been merged.

It removes the dependency on a deleted snapshot build of the protobuf-gradle-plugin and updates to the official 0.9.6 release. The changes eliminate the temporary workaround that was needed for Java 9.1 compatibility.

Changes:

- Updated to official `protobuf-gradle-plugin` version 0.9.6
- Removed buildscript block with JitPack repository and snapshot dependency
verawu pushed a commit to verawu/elasticsearch that referenced this pull request Jul 21, 2026
* Update Gradle wrapper to 9.1.0 (#132970)

* WIP gradle 9.0 update

* Fix build integration tests
* Avoid usage of archives configuration
* Reference PR build for protobuf plugin

Temporary fix until the PR against the protobuf plugin at
google/protobuf-gradle-plugin#786
is merged.

(cherry picked from commit 163c627163b61a1e2f37a217f854593638b3b9c8)

# Conflicts:
#	build-tools-internal/src/main/resources/minimumGradleVersion
#	x-pack/plugin/otel-data/build.gradle

* Delete config.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.