Inline deprecated constant value#779
Merged
Merged
Conversation
ejona86
approved these changes
Apr 10, 2025
Collaborator
|
Thanks. I took a look to see if there are any other |
Contributor
Author
|
Thanks for the quick reply! FYI, we're probably going to delay removal of this until Gradle 10.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are removing the deprecated
ArtifactAttributesclass from Gradle.It is still used here: https://github.com/google/protobuf-gradle-plugin/blob/master/src/main/groovy/com/google/protobuf/gradle/ProtobufPlugin.groovy#L310.
It can be replaced by
Attribute.of("artifactType", String). This PR does this.Or, if you upgrade your build to Gradle >= 7.3, you can use the predefined
ArtifactTypeDefinition.ARTIFACT_TYPE_ATTRIBUTE.