Set default command length limit to 64k#653
Merged
Merged
Conversation
Collaborator
|
cc #633 |
Contributor
Author
|
@rougsig do you know why my test is failing. It says internal error and I don't seem to have access to check more? |
Collaborator
|
One moment. |
Collaborator
|
No logs. Looks like github problem. Restarted it. |
Contributor
Author
|
@rougsig I fixed the test and the codenarc failure, can you please rerun the workflow? |
Collaborator
|
@karthikrg done |
Contributor
Author
|
@rougsig Thank you. All checks passed. If it looks ok, can you review please? |
rougsig
approved these changes
Jan 7, 2023
ejona86
approved these changes
Jan 8, 2023
|
Narrator: "the default was not reasonable" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various operating systems impose command length limits that are far short of the current Integer.MAX_VALUE default. For example, on MacOS 12.6.2,
getconf ARG_MAXreturns1048576.Hence set a reasonable default command line length limit of 64k.