Merged
Conversation
Part of google#97. I don't think this requires a schema bump, since we previously unconditionally tried to parse the module.json regardless of whether or not it was present, which means non-module directories would have been an error.
enh-google
approved these changes
Jun 2, 2020
DanAlbert
pushed a commit
to DanAlbert/prefab
that referenced
this pull request
Aug 21, 2020
Some file browsers helpfully create extra hidden files in any directory they view. It may have been better to just ignore anything without a module.json, but google#106 made module.json optional, so technically any directory is a valid module now and we need a new schema revision to change that behavior. We could alternatively add an explicit module list to prefab.json, but that would also require a new schema revision. For now, just ignore all files (fixes the .DS_Store case) and any hidden directories (just in case).
DanAlbert
pushed a commit
that referenced
this pull request
Sep 14, 2020
Some file browsers helpfully create extra hidden files in any directory they view. It may have been better to just ignore anything without a module.json, but #106 made module.json optional, so technically any directory is a valid module now and we need a new schema revision to change that behavior. We could alternatively add an explicit module list to prefab.json, but that would also require a new schema revision. For now, just ignore all files (fixes the .DS_Store case) and any hidden directories (just in case).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #97.
I don't think this requires a schema bump, since we previously
unconditionally tried to parse the module.json regardless of whether
or not it was present, which means non-module directories would have
been an error.