Fix canvas to fill the full height.#937
Merged
Merged
Conversation
The canvas used to scale itself to the aspect ratio of the full graph, which might be fairly wide. That means even while zooming, the original aspect ratio is preserved and only a 'letterbox' is shown. This CSS change fixes that. Fixes: google#835 Signed-off-by: Henner Zeller <[email protected]>
Member
Author
|
This shows a zoomed-in view of a graph that started out fairly wide and even after zooming occipies the same aspect ratio before, but uses the full available screenwidth afterwards: Before:
After:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #937 +/- ##
==========================================
+ Coverage 66.86% 66.89% +0.03%
==========================================
Files 44 44
Lines 9824 9870 +46
==========================================
+ Hits 6569 6603 +34
- Misses 2794 2828 +34
+ Partials 461 439 -22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
The Linux tests look like they fail due to some unrelated reason. |
aalexand
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The canvas used to scale itself to the aspect ratio of the full graph, which might be fairly wide. That means even while zooming, the original aspect ratio is preserved and only a 'letterbox' is shown.
This CSS change fixes that.
Fixes: #835