Fix 'show source [in new tab]' under -lines#912
Merged
Conversation
aalexand
reviewed
Nov 22, 2024
aalexand
left a comment
aalexand
left a comment
Collaborator
There was a problem hiding this comment.
Could you add a comment that explains the "why" behind the regexp? (no need to explain the regexp mechanics itself)
Contributor
Author
|
Sure, done! |
aalexand
approved these changes
Dec 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #912 +/- ##
==========================================
+ Coverage 66.86% 66.97% +0.10%
==========================================
Files 44 44
Lines 9824 9855 +31
==========================================
+ Hits 6569 6600 +31
- Misses 2794 2816 +22
+ Partials 461 439 -22 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Thanks @aalexand - could you merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this patch, it's possible to navigate from the (new and now only) flame graph to the source code for a box.