feat: merge extractor and detector flags into plugins#2146
Merged
another-rex merged 11 commits intogoogle:mainfrom Aug 7, 2025
Merged
feat: merge extractor and detector flags into plugins#2146another-rex merged 11 commits intogoogle:mainfrom
extractor and detector flags into plugins#2146another-rex merged 11 commits intogoogle:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2146 +/- ##
==========================================
- Coverage 67.58% 67.50% -0.08%
==========================================
Files 171 170 -1
Lines 16271 16232 -39
==========================================
- Hits 10996 10957 -39
Misses 4600 4600
Partials 675 675 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
G-Rath
force-pushed
the
plugins/use-plugins
branch
3 times, most recently
from
8424175 to
8a1fd47
Compare
another-rex
approved these changes
Aug 7, 2025
Collaborator
another-rex
left a comment
another-rex
left a comment
There was a problem hiding this comment.
LGTM as well, though need to resolve the conflicts before the diffs are correct.
G-Rath
force-pushed
the
plugins/use-plugins
branch
from
c061d08 to
677cb71
Compare
another-rex
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the external distinction between extractors and detectors in favor of just plugins, which matches how they're represented in scalibr