fix: add text field into shortdescription and fulldescription, update snap…#2072
Merged
another-rex merged 1 commit intogoogle:mainfrom Jul 15, 2025
brabster:fix-description-text-sarif-210-issue
Merged
fix: add text field into shortdescription and fulldescription, update snap…#2072another-rex merged 1 commit intogoogle:mainfrom brabster:fix-description-text-sarif-210-issue
another-rex merged 1 commit intogoogle:mainfrom
brabster:fix-description-text-sarif-210-issue
Conversation
Contributor
Author
|
Hm, just checked an attempt to upload to GitHub, seems there might be more issues than those two. |
another-rex
approved these changes
Jul 15, 2025
another-rex
changed the title
Collaborator
|
Huh interesting, I'm not sure how you got the field "instance", as it doesn't show up in any of the tests snapshots we have in osv-scanner. |
Collaborator
Collaborator
|
I'll push an update to osv-scanner-action to make sure people using the github action gets the fix immediately, and we'll followup with a patch release next week. There has been some other changes merged in the mean time that we want to have additional bake time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…shots
Fixes #2071
I think the code and snapshots were updated as part of #1985, but the required "text" property in the *description fields was lost and not detected.
I think this change restores the previous behaviour with respect to these fields - I can't yet be sure there are no other breaking changes