Skip to content

[Redis] [Draft: waiting for upstream] Initial integration. #4643

Closed
DavidKorczynski wants to merge 2 commits intogoogle:masterfrom
DavidKorczynski:redis
Closed

[Redis] [Draft: waiting for upstream] Initial integration. #4643
DavidKorczynski wants to merge 2 commits intogoogle:masterfrom
DavidKorczynski:redis

Conversation

@DavidKorczynski
Copy link
Collaborator

No description provided.

Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We approve of adding this project, just let us know when it is ready to land.

@@ -0,0 +1,44 @@
#!/bin/bash -eu
#
# Copyright 2016 Google Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 2020.


LD="${CXX}"
export LDFLAGS="$CFLAGS"
export MYLDFLAGS="$CFLAGS"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed or is it debug code?

@jonathanmetzman jonathanmetzman marked this pull request as draft December 2, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants