Improve compile_native_go_fuzzer command to detect fuzzer functions more precisely.#13220
Improve compile_native_go_fuzzer command to detect fuzzer functions more precisely.#13220sudiptob2 wants to merge 1 commit intogoogle:masterfrom
compile_native_go_fuzzer command to detect fuzzer functions more precisely.#13220Conversation
nareddyt
left a comment
nareddyt
left a comment
There was a problem hiding this comment.
@AdamKorcz PTAL since you added this script, fairly trivial change
|
/gcbrun trial_build.py go-attestation go-coredns go-dns go-ethereum go-json-iterator go-redis go-sftp go-snappy go-sqlite3 golang golang-protobuf gonids grpc-go syzkaller kubernetes --sanitizer coverage --fuzzing-engine libfuzzer |
sudiptob2
force-pushed
the
fix/compile-script
branch
from
d68bb00 to
51b8c4f
Compare
|
@sudiptob2 can you let me know when you have finished making commits? I need to launch an experiment and would prefer to do this once you believe this is ready |
|
@DavidKorczynski hey got it, its ready. I just rebased it. I wont rebase it anymore unless you are done with the experiment. |
|
/gcbrun trial_build.py go-attestation go-coredns go-dns go-ethereum go-json-iterator go-redis go-sftp go-snappy go-sqlite3 golang golang-protobuf gonids grpc-go syzkaller kubernetes --sanitizer coverage --fuzzing-engine libfuzzer |
|
@DavidKorczynski Do we think this is ready? |
yes |
|
@DavidKorczynski @AdamKorcz any update on when we can merge this PR? |
|
/gcbrun trial_build.py go-attestation go-coredns go-dns go-ethereum go-json-iterator go-redis go-sftp go-snappy go-sqlite3 golang golang-protobuf gonids grpc-go syzkaller kubernetes --sanitizer coverage --fuzzing-engine libfuzzer |
|
/gcbrun trial_build.py go --fuzzing-engines libfuzzer --sanitizers coverage address |
5 participants
The
grepcommand used incompile_native_go_fuzzerdoes not work correctly when fuzzers have similar names. Consider the following example:We have two fuzzers:
FuzzGatewayAPIToXDSFuzzGatewayAPIToXDSWithGatewayClassCompile command:
Since the target string appears in both fuzzer names, the grep command returns 2 matches instead of 1.
This PR adds an additional
"("to more precisely identify the fuzzer name.Also, added
set -xfor better debugging.