Update SWIG flags for OpenBSD#4266
Merged
Mizux merged 1 commit intogoogle:stablefrom Jun 10, 2024
ron-at-swgy:python-swig-openbsd
Merged
Update SWIG flags for OpenBSD#4266Mizux merged 1 commit intogoogle:stablefrom ron-at-swgy:python-swig-openbsd
Mizux merged 1 commit intogoogle:stablefrom
ron-at-swgy:python-swig-openbsd
Conversation
ron-at-swgy
commented
Jun 8, 2024
Mizux
reviewed
Jun 10, 2024
This commit ensures the `SWIGWORDSIZENN` defines are not set when building on OpenBSD.
Contributor
Author
|
@Mizux the build completed successful without |
Mizux
pushed a commit
that referenced
this pull request
Jun 11, 2024
This commit ensures the `SWIGWORDSIZENN` defines are not set when building on OpenBSD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4249
This commit adds an OpenBSD specific flag for use with SWIG,
-DSMALL_LONG, and further specifies the-DSWIGWORDSIZEflagconditions to exclude OpenBSD (as is done with Apple).
Validation of CMake platform check:
-- system name: OpenBSD -- On OpenBSD CMake Error at cmake/python.cmake:43 (message): stop cmake configure to fast iterate ! (to remove after dev/debug) Call Stack (most recent call first): CMakeLists.txt:429 (include)Result
This change, combined with #4259 and #4257 allows me to build the
.whlfile forthe python
or-toolspackage. I then validated theCBC_MIXED_INTEGER_PROGRAMMINGand
GLOPsolvers with a simple linear programming problem in the Jupyter Labenvironment.