Add static code analysis on commit and fix CodeQL errors#1507
Add static code analysis on commit and fix CodeQL errors#1507
Conversation
Create an action to run static code analysis on demand.
|
Seems like there are issues in the autobuilder. github/codeql-action#824 |
|
What happens if you just use a normal build process instead of the auto-build provided by codeql (probably you’re already doing that though) |
Changing the build to something normal seems to work fine. Thanks! I will address the issues next week |
|
Ah, now similar issues show up in the CI: https://github.com/google/oboe/runs/5504278249 |
|
Great! Thanks for fixing these errors |
|
Do you plan to add codeQl to your repo or just fix the overflow warnings? I think splitting the fixes in a separate PR would make sense such that you can decide if CodeQL should or shouldn’t be added. |
|
Is there a downside of adding CodeQl to the CI besides the checks taking a bit longer? |
|
Not really. |
|
Fixes #1506 |
|
Great thanks for fixing and merging! |
Create an action to run static code analysis on demand.
After this is created, a separate PR will be created to fix linker issues described in #1506