Documented the issue with checking isPossible only for default country#3771
Merged
tvislavski merged 7 commits intomasterfrom Dec 24, 2024
Merged
Documented the issue with checking isPossible only for default country#3771tvislavski merged 7 commits intomasterfrom
tvislavski merged 7 commits intomasterfrom
Conversation
…hese modules belong to the same package as core libphonenumber library, which leads to the split package problem with Java modules.
…omatic-module-names # Conflicts: # java/carrier/pom.xml # java/geocoder/pom.xml
mandlil
approved these changes
Dec 19, 2024
kkeshava
approved these changes
Dec 24, 2024
giggsey
added a commit
to giggsey/libphonenumber-for-php
that referenced
this pull request
Jan 15, 2025
giggsey
added a commit
to giggsey/libphonenumber-for-php-lite
that referenced
this pull request
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documented the issue with checking isPossible only for default country for Java, C++ and JS. Updated both demos to