You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We tested with your PR changes, internally we are getting testcase failures for the string type phonenumbers.
Instead of writing changes in matchEntirely function, you can write here(
We tested with your PR changes, internally we are getting testcase failures for the string type phonenumbers. Instead of writing changes in matchEntirely function, you can write here(
) like new RegExp('^(?:' + generalDesc.getNationalNumberPatternOrDefault() + ')$').
Hello,
Thank you for your thoughtful review.
While testing with the test cases in this repository, I noticed that a Russian uppercase phone number was incorrectly identified as an invalid number. To address this, I added a case-insensitive option to the regular expression, and all test cases passed successfully.
I also saw your PR (#3770). I think addressing the root cause by modifying the "matchesEntirely" function might be necessary since it is called from multiple places. However, if your proposed change adequately resolves the issue, I think your approach is also a good solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without "()", when many conditions exist and former one is matched, it returns the wrong value. So adding "()" for the regex
I think it doesn't happen in Java and cpp
[related issue] (raised by myself)
https://issuetracker.google.com/issues/383824582
[java]
https://github.com/google/libphonenumber/blob/master/java/libphonenumber/src/com/google/i18n/phonenumbers/internal/RegexBasedMatcher.java#L49-L56
[cpp]
https://github.com/google/libphonenumber/blob/master/cpp/src/phonenumbers/regex_based_matcher.cc#L51-L65