-
Notifications
You must be signed in to change notification settings - Fork 367
Migrate away from a deprecated compilerOptions KGP API #2703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ting-yuan
merged 3 commits into
google:main
from
hfmehmed:migrate-from-deprecated-kgp-api
Nov 19, 2025
Merged
Migrate away from a deprecated compilerOptions KGP API #2703
ting-yuan
merged 3 commits into
google:main
from
hfmehmed:migrate-from-deprecated-kgp-api
Nov 19, 2025
+45
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fde017c to
e65d1e7
Compare
Replacement is to the use the compileTaskProvider
e65d1e7 to
877ec6c
Compare
hfmehmed
commented
Nov 18, 2025
gradle-plugin/src/main/kotlin/com/google/devtools/ksp/gradle/KspAATask.kt
Show resolved
Hide resolved
gradle-plugin/src/main/kotlin/com/google/devtools/ksp/gradle/KspAATask.kt
Outdated
Show resolved
Hide resolved
Remove debug print statement from KspAAWorkerAction.
ting-yuan
approved these changes
Nov 19, 2025
HLCaptain
reviewed
Nov 29, 2025
| assert("w: [ksp] [workload_debug] Mangled name for internalFun: internalFun\$workload_debug" in outputs) | ||
| assert("w: [ksp] [workload_release] Mangled name for internalFun: internalFun\$workload_release" in outputs) | ||
| assert("w: [ksp] [workload] Mangled name for internalFun: internalFun\$workload" in outputs) | ||
| assert("w: [ksp] [workload] Mangled name for internalFun: internalFun\$workload" in outputs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this duplication intentional?
| assert("w: [ksp] [workload_debug] Mangled name for internalFun: internalFun\$workload_debug" in outputs) | ||
| assert("w: [ksp] [workload_release] Mangled name for internalFun: internalFun\$workload_release" in outputs) | ||
| assert("w: [ksp] [workload] Mangled name for internalFun: internalFun\$workload" in outputs) | ||
| assert("w: [ksp] [workload] Mangled name for internalFun: internalFun\$workload" in outputs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this duplication intentional as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement is to the use the compileTaskProvider
This change also fixes the discrepancy between Kotlin compiler and KSP
moduleNamewhich results in different generated internal functionsFixes #2701