Skip to content

Conversation

@hfmehmed
Copy link
Collaborator

@hfmehmed hfmehmed commented Nov 18, 2025

Replacement is to the use the compileTaskProvider

This change also fixes the discrepancy between Kotlin compiler and KSP moduleName which results in different generated internal functions

Fixes #2701

@hfmehmed hfmehmed force-pushed the migrate-from-deprecated-kgp-api branch 3 times, most recently from fde017c to e65d1e7 Compare November 18, 2025 18:39
milonmilonkhan742-web

This comment was marked as spam.

@hfmehmed hfmehmed requested a review from ting-yuan November 18, 2025 19:12
Replacement is to the use the compileTaskProvider
@hfmehmed hfmehmed force-pushed the migrate-from-deprecated-kgp-api branch from e65d1e7 to 877ec6c Compare November 18, 2025 19:14
Remove debug print statement from KspAAWorkerAction.
@ting-yuan ting-yuan merged commit 7c6da70 into google:main Nov 19, 2025
3 checks passed
assert("w: [ksp] [workload_debug] Mangled name for internalFun: internalFun\$workload_debug" in outputs)
assert("w: [ksp] [workload_release] Mangled name for internalFun: internalFun\$workload_release" in outputs)
assert("w: [ksp] [workload] Mangled name for internalFun: internalFun\$workload" in outputs)
assert("w: [ksp] [workload] Mangled name for internalFun: internalFun\$workload" in outputs)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this duplication intentional?

assert("w: [ksp] [workload_debug] Mangled name for internalFun: internalFun\$workload_debug" in outputs)
assert("w: [ksp] [workload_release] Mangled name for internalFun: internalFun\$workload_release" in outputs)
assert("w: [ksp] [workload] Mangled name for internalFun: internalFun\$workload" in outputs)
assert("w: [ksp] [workload] Mangled name for internalFun: internalFun\$workload" in outputs)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this duplication intentional as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[KSP] Mangled names for internal functions are incorrect when compiled on AGP 9

5 participants