Fix regression related to AGP 8.7.0 and below #2694
Merged
+76
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfmehmed
changed the title
hfmehmed
changed the title
hfmehmed
force-pushed
the
add-old-agp-tests
branch
5 times, most recently
from
3375e22 to
5444ce4
Compare
ting-yuan
reviewed
Nov 5, 2025
gradle-plugin/src/main/kotlin/com/google/devtools/ksp/gradle/KspConfigurations.kt
Show resolved
Hide resolved
ting-yuan
approved these changes
Nov 5, 2025
hfmehmed
force-pushed
the
add-old-agp-tests
branch
from
5444ce4 to
60a0698
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #2656 where we check if target is of a specific type which is available since AGP 8.8.0
This leads to runtime failure for project using 8.8.0 and below.
Also adding more tests with older AGP versions.