This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Move userCreds func to cmd/client #975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/core can't reference anything in /impl.
Codecov Report
@@ Coverage Diff @@
## master #975 +/- ##
==========================================
- Coverage 49.77% 49.73% -0.05%
==========================================
Files 29 29
Lines 2043 2043
==========================================
- Hits 1017 1016 -1
- Misses 846 847 +1
Partials 180 180
Continue to review full report at Codecov.
|
pav-kv
approved these changes
May 15, 2018
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Jul 23, 2018
Fixes a bug where the client was not sending oauth user credentials. Post google#975, client creds do not need to be passed with each RPC, and as such, an authenticated, yet anonymous mode of authentication is no longer needed, we can just use unauthenticated calls for the public api. If we need to bring this back at a later point for spam reasons, we can. In the meantime, deleted code is best code.
Merged
gdbelvin
added a commit
that referenced
this pull request
Jul 23, 2018
* Remove service-key Fixes a bug where the client was not sending oauth user credentials. Post #975, client creds do not need to be passed with each RPC, and as such, an authenticated, yet anonymous mode of authentication is no longer needed, we can just use unauthenticated calls for the public api. If we need to bring this back at a later point for spam reasons, we can. In the meantime, deleted code is best code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous few PRs (#974 #973 ) migrated authentication and authorization from
/coreto implementation specific grpc interceptors.This PR refactors the
PerRPCCredentialscreation out of/core/clientinto implementation specific/cmd/keytransparency-client. TheCallOptionseven has the flexibility to not return any options for situations where an implementation has chosen to not implement authorization controls.