This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Also move authorization to the grpc interceptor #974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that authentication is happening in a grpc interceptor, we don't need any authentication code in core/. We also get the added benefit of keeping the `validatedSecurityKey` private to the authentication package.
Codecov Report
@@ Coverage Diff @@
## master #974 +/- ##
==========================================
+ Coverage 49.68% 49.77% +0.09%
==========================================
Files 29 29
Lines 2041 2043 +2
==========================================
+ Hits 1014 1017 +3
+ Misses 847 846 -1
Partials 180 180
Continue to review full report at Codecov.
|
Martin2112
approved these changes
May 11, 2018
impl/authentication/context.go
Outdated
| type Authenticator interface { | ||
| // ValidateCreds authenticate the information present in ctx. | ||
| ValidateCreds(ctx context.Context) (*SecurityContext, error) | ||
| // FromContext returns a ValidatedSecurity from the current context. |
Contributor
There was a problem hiding this comment.
This doc wasn't updated for the rename (x2 mentions)
gdbelvin
force-pushed
the
f/auth/authz
branch
2 times, most recently
from
88290c7 to
8dc2ba3
Compare
* master: Move authentication to grpc interceptor (google#973) Add UnitTest for PaginateHistory (google#968) Remove unused `UserProfile` message (google#972) Update default paths (google#910)
This was referenced May 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the move from server based authentication and authorization to grpc interceptor based authorization and authentication.
This should make it much easier for specific deployments to swap in their own appropriate authentication and authorization functions.
Diffbase #973