Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Conversation

@gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented May 9, 2018

UserProfile is unused. Rather than forcing a particular format on
applications, we give them opaque bytes in Committed.Data.

UserProfile is unused.  Rather than forcing a particular format on
applications, we give them opaque bytes in Committed.Data.
@gdbelvin gdbelvin requested a review from Martin2112 May 9, 2018 15:52
@codecov-io
Copy link

Codecov Report

Merging #972 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #972      +/-   ##
==========================================
- Coverage   47.34%   47.29%   -0.05%     
==========================================
  Files          28       28              
  Lines        2034     2034              
==========================================
- Hits          963      962       -1     
- Misses        894      895       +1     
  Partials      177      177
Impacted Files Coverage Δ
core/client/client.go 14.77% <0%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a662a3e...28f8663. Read the comment docs.

@gdbelvin gdbelvin requested a review from phad May 10, 2018 15:53
@gdbelvin gdbelvin merged commit 29dfa03 into google:master May 11, 2018
@gdbelvin gdbelvin deleted the api/unused branch May 11, 2018 18:12
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request May 13, 2018
* master:
  Move authentication to grpc interceptor (google#973)
  Add UnitTest for PaginateHistory (google#968)
  Remove unused `UserProfile` message (google#972)
  Update default paths (google#910)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants